Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Added McMMO anvil fix

Open Intybyte opened this issue 1 year ago โ€ข 2 comments

Description

Fixing a bug where having mcmmo would allow you to repair for instance a gold chestplate with 4k gold, and then dismantling it for normal gold, or using lead to repair an iron sword. You can use slimefun items to repair vanilla items and use items to repair Slimefun items

Proposed changes

Added and event listener for the repair event. Add a translation key for the error mcmmo.anvil-repair

Related Issues (if applicable)

Resolves #4181

Checklist

  • [X] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [X] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [X] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [X] I followed the existing code standards and didn't mess up the formatting.
  • [ ] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

Intybyte avatar May 03 '24 16:05 Intybyte

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. โค๏ธ

Branch naming convention Label
feature/** ๐ŸŽˆ Feature
fix/** โœจ Fix
chore/** ๐Ÿงน Chores
api/** ๐Ÿ”ง API
performance/** ๐Ÿ’ก Performance Optimization
compatibility/** ๐Ÿค Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! ๐Ÿ‘€

github-actions[bot] avatar May 03 '24 16:05 github-actions[bot]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 34d861b5

https://preview-builds.walshy.dev/download/Slimefun/4182/34d861b5

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar May 04 '24 09:05 github-actions[bot]