Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Writtenbook soulbound fix

Open ShiftSad opened this issue 1 year ago โ€ข 3 comments

Description

When cloning an Written Book in the crafting slot with a Writable Book, it keeps all the item data, like the SoulBound Status. With should not be intended since it "dupes it".

Proposed changes

Simply setting the soul bound status false when a book is cloned

Related Issues (if applicable)

Checklist

  • [ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [ ] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

ShiftSad avatar Apr 10 '24 14:04 ShiftSad

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. โค๏ธ

Branch naming convention Label
feature/** ๐ŸŽˆ Feature
fix/** โœจ Fix
chore/** ๐Ÿงน Chores
api/** ๐Ÿ”ง API
performance/** ๐Ÿ’ก Performance Optimization
compatibility/** ๐Ÿค Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! ๐Ÿ‘€

github-actions[bot] avatar Apr 10 '24 14:04 github-actions[bot]

This is my first pull request, if there is anything I can improve I would be glad to do so. I have already noticed the labels, next time I'll make sure to use them.

ShiftSad avatar Apr 10 '24 15:04 ShiftSad

Slimefun preview build

A Slimefun preview build is available for testing! Commit: ccc9c4c5

https://preview-builds.walshy.dev/download/Slimefun/4169/ccc9c4c5

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar Apr 12 '24 23:04 github-actions[bot]