Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

fix: set hover event to null for texts after update warning

Open ybw0014 opened this issue 1 year ago • 3 comments
trafficstars

Description

When your mouse hovers over java/metrics version, it will show the update warning too. Set the hover event to null to let hover event only show for the "update available" text.

Proposed changes

Set the hover event to null for texts after update warning.

Related Issues (if applicable)

Checklist

  • [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [ ] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

ybw0014 avatar Feb 24 '24 18:02 ybw0014

Your Pull Request was automatically labelled as: "✨ Fix" Thank you for contributing to this project! ❤️

github-actions[bot] avatar Feb 24 '24 18:02 github-actions[bot]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 36e14425

https://preview-builds.walshy.dev/download/Slimefun/4143/36e14425

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar Feb 24 '24 18:02 github-actions[bot]

Thank you for moving this from the other PR, we'll get back to that when we figure out the future of RC

WalshyDev avatar Feb 25 '24 15:02 WalshyDev