Slimefun4
Slimefun4 copied to clipboard
Make the CropGrowthAccelerator take speed into account (grow multiple…
… blocks at once)
Description
This fixes the crop growth accelerator and makes it work as is advertised. Before it's only accelerating the growth of one block at at time instead of based on the Speed parameter of the accelerator.
Proposed changes
Just take into account the speed of the accelerator block
Related Issues (if applicable)
Checklist
- [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
- [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
- [x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
- [x] I followed the existing code standards and didn't mess up the formatting.
- [x] I did my best to add documentation to any public classes or methods I added.
- [ ] I have added
NonnullandNullableannotations to my methods to indicate their behaviour for null values - [ ] I added sufficient Unit Tests to cover my code.
Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️
| Branch naming convention | Label |
|---|---|
feature/** |
🎈 Feature |
fix/** |
✨ Fix |
chore/** |
🧹 Chores |
api/** |
🔧 API |
performance/** |
💡 Performance Optimization |
compatibility/** |
🤝 Compatibility |
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀
Slimefun preview build
A Slimefun preview build is available for testing! Commit: b5b395ce
https://preview-builds.walshy.dev/download/Slimefun/4107/b5b395ce
Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!
Can you rebase this?