Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Add Horizontal Offset support to Holograms

Open test137E29B opened this issue 2 years ago • 2 comments

Description

Hologram projectors are really nice things to use, but they lack horizontal offset support meaning any design without a central block annoyingly has an offset hologram. This PR adds support for them to be up to 32 blocks away horizontally. This offers more options to hide the projector in the wall or ceiling, while also allowing them to be centered nicely along any axis.

Proposed changes

  • Add X offset to hologram projectors
  • Add Z offset to hologram projectors
  • Clean up code a little with the new additions

Related Issues (if applicable)

Checklist

  • [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [x] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [x] I did my best to add documentation to any public classes or methods I added.
  • [x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

test137E29B avatar Nov 07 '23 13:11 test137E29B

Your Pull Request was automatically labelled as: "🎈 Feature" Thank you for contributing to this project! ❤️

github-actions[bot] avatar Nov 07 '23 13:11 github-actions[bot]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 0124d76b

https://preview-builds.walshy.dev/download/Slimefun/4018/0124d76b

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar Nov 07 '23 13:11 github-actions[bot]