Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Published 20 hours ago • verified publisher icon Slimefun

added bamboo to the saw table

Open J3fftw1 opened this issue 1 year ago • 9 comments

Description

added bamboo to the saw table

Proposed changes

Added bamboo blocks > bamboo plank and Stripped bamboo blocks > bamboo plank in the saw mil

Related Issues (if applicable)

Checklist

  • [ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [x] I did my best to add documentation to any public classes or methods I added.
  • [x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

J3fftw1 avatar Jun 29 '23 16:06 J3fftw1

Your Pull Request was automatically labelled as: "🎈 Feature" Thank you for contributing to this project! ❤️

github-actions[bot] avatar Jun 29 '23 16:06 github-actions[bot]

Slimefun preview build

A Slimefun preview build is available for testing! Commit: e9f702c9

https://preview-builds.walshy.dev/download/Slimefun/3878/e9f702c9

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

github-actions[bot] avatar Jun 29 '23 16:06 github-actions[bot]

bamboo blocks / stripped bamboo blocks are tagged in Tag.BAMBOO_BLOCKS not Tag.LOGS

SchnTgaiSpock avatar Jun 29 '23 17:06 SchnTgaiSpock

This cant be merged for some reason bukkit thinks the tag is empty

J3fftw1 avatar Jul 11 '23 16:07 J3fftw1

Bukkit what the fuck Is it a thing that was broken in 1.20.0 and fixed in 1.20.1, has it been reported to them at all, is there something else at play...? Do we know anything basically?

Sfiguz7 avatar Jul 11 '23 16:07 Sfiguz7

i dont see how this is broken Bukkit litteraly gets the tag from minecraft and turns it into theirs.

also it doesnt work on what ever version...

J3fftw1 avatar Jul 11 '23 17:07 J3fftw1

Bumping this: are there new bamboo things now? Is the tag fixed now?

Sfiguz7 avatar Dec 07 '23 09:12 Sfiguz7

nope the tag is still null

J3fftw1 avatar Dec 10 '23 20:12 J3fftw1

nvm this seems to be a mockbukkit issue. I can use the tag properly when i skip tests. We really need to update mockbukkit

J3fftw1 avatar Dec 10 '23 20:12 J3fftw1