Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Soulbound items disappear when restarting the server mid-deathscreen

Open KiinoOFC opened this issue 2 years ago โ€ข 16 comments

โ— Checklist

  • [X] I am using the official english version of Slimefun and did not modify the jar.
  • [X] I am using an up to date "DEV" (not "RC") version of Slimefun.
  • [X] I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • [X] I searched for similar open issues and could not find an existing bug report on this.

๐Ÿ“ Description

When a player dies with Soulbound items. After restarting the server, the items disappear

๐Ÿ“‘ Reproduction Steps

  1. Have items with Soulbound
  2. Then you die
  3. Restart the server
  4. Join the server
  5. Checks if Soulbound items are there

๐Ÿ’ก Expected Behavior

Soulbound items do not disappear

๐Ÿ“ท Screenshots / Videos

Before restarting image

After restart image

๐Ÿ“œ Server Log

no errors to log

๐Ÿ“‚ /error-reports/ folder

no errors to folder

๐Ÿ’ป Server Software

Paper

๐ŸŽฎ Minecraft Version

1.17.x

โญ Slimefun version

Paper git-Paper-411 (MC: 1.17.1) Slimefun DEV - 1043 (git 4bfc4f06) Metrics-Module #28 Java 17

๐Ÿงญ Other plugins

No response

KiinoOFC avatar Feb 20 '23 19:02 KiinoOFC

please provide your full plugin list and if you have any datapacks installed

Boomer-1 avatar Feb 20 '23 19:02 Boomer-1

OBS: Have to restart server on death screen

no data pack installed plugins: image

KiinoOFC avatar Feb 21 '23 00:02 KiinoOFC

over many repeated attempts i cannot duplicate this with 1.17.1 and dev 1043

Boomer-1 avatar Feb 21 '23 00:02 Boomer-1

what mods are you using?

Boomer-1 avatar Feb 21 '23 00:02 Boomer-1

no mod

KiinoOFC avatar Feb 21 '23 01:02 KiinoOFC

well, you have at least one based on the picture you provided of your inventory. something you've installed, in the server or the client is interfering. without all the info we can't help

Boomer-1 avatar Feb 21 '23 02:02 Boomer-1

I managed to fix my OBS, maybe this will help

https://user-images.githubusercontent.com/58773688/220232637-c8984e5a-a6c0-45c2-a760-aab205f5870a.mp4

https://user-images.githubusercontent.com/58773688/220232732-6149c918-7978-4756-8d74-6d88977ccbf4.mp4

KiinoOFC avatar Feb 21 '23 02:02 KiinoOFC

and the server was created from scratch to test this, just with the addition of slimefun

KiinoOFC avatar Feb 21 '23 02:02 KiinoOFC

you have a mod installed. numbers in your inventory is not vanilla

Boomer-1 avatar Feb 21 '23 02:02 Boomer-1

texturepack

KiinoOFC avatar Feb 21 '23 02:02 KiinoOFC

with the exact same server, minecraft version and slimefun version i cannot recreate it. I've tried netherite armor, diamond armor and it stays everytime. try removing the pack and do it again

Boomer-1 avatar Feb 21 '23 02:02 Boomer-1

ok. i think i figured it out. you're shutting your server down before the player clicks respawn. that's the only way i've been able to do it. so in the extreme possibility that the player dies in that millisecond, and they can't click respawn it disappears. in that brief moment between death and the server restart, the event cant fire. iirc, it fires on the click of respawn. because the data can't be saved thru a restart. not sure if there's a fix to that or not. Dev's will have to look into it.

Boomer-1 avatar Feb 21 '23 02:02 Boomer-1

So whomever wants to look into this, the key here is the server shuts down before the player clicks respawn. that key moment is the issue

Boomer-1 avatar Feb 21 '23 02:02 Boomer-1

@Boomer-1 i would assume this also happens when the player disconnects and joins back after he died?

J3fftw1 avatar Feb 22 '23 10:02 J3fftw1

ok. i think i figured it out. you're shutting your server down before the player clicks respawn. that's the only way i've been able to do it. so in the extreme possibility that the player dies in that millisecond, and they can't click respawn it disappears. in that brief moment between death and the server restart, the event cant fire. iirc, it fires on the click of respawn. because the data can't be saved thru a restart. not sure if there's a fix to that or not. Dev's will have to look into it.

what about storing it as NBT on the player? in the .dat

RayBytes avatar Feb 22 '23 11:02 RayBytes

this is also happening on my server, players are reporting this

SrMonsterYT avatar Mar 06 '23 16:03 SrMonsterYT