Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Backpack dupe items

Open ybw0014 opened this issue 2 years ago โ€ข 3 comments

โ— Checklist

  • [X] I am using the official english version of Slimefun and did not modify the jar.
  • [X] I am using an up to date "DEV" (not "RC") version of Slimefun.
  • [X] I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • [X] I searched for similar open issues and could not find an existing bug report on this.

๐Ÿ“ Description

Backpacks can be used to dupe items.

Two players, a backpack, and backpack upgrade materials are needed.

๐Ÿ“‘ Reproduction Steps

  1. Player A holds a backpack in main hand, and a portable crafting table in off hand.
  2. Player A opens a backpack, and put items that need to be duped (e.g. 64x diamonds).
  3. Player A press F to switch backpack & portable, and switch back. (Not closing backpack)
  4. Player A drops the backpack, without closing the backpack.
  5. Player B picks up the backpack from Player A, upgrade it in enhanced crafting table.
  6. Player B opens the backpack, gets the 64x diamonds.
  7. Player A gets 64x diamonds, in total, 128x diamonds.

๐Ÿ’ก Expected Behavior

The opened backpacks are closed.

๐Ÿ“ท Screenshots / Videos

https://youtu.be/IFFCafxr7bQ

๐Ÿ“œ Server Log

N/A

๐Ÿ“‚ /error-reports/ folder

N/A

๐Ÿ’ป Server Software

Paper

๐ŸŽฎ Minecraft Version

1.19.x

โญ Slimefun version

DEV - 1027

๐Ÿงญ Other plugins

No

ybw0014 avatar Aug 30 '22 21:08 ybw0014

Thanks for the detailed bug report!

The issue should be fixed within the latest commit. Players should no longer be able to swap the backpack from hand to another while having the backpack open. Additionally, a safeguard was added to close the backpack inventory before upgrading its size.

TheBusyBiscuit avatar Sep 29 '22 10:09 TheBusyBiscuit

bug continues in version DEV - 1033 (git 5455fb08)

video: https://streamable.com/yzib9s

SrMonsterYT avatar Oct 03 '22 17:10 SrMonsterYT

dupe is still working I can do it right now if I need to, in the video I show that I'm using version 1033

pump61 avatar Oct 04 '22 21:10 pump61

please fix this, people are abusing it, and if I remove it from my server I will lose a lot of items.

SrMonsterYT avatar Oct 07 '22 16:10 SrMonsterYT

You could temporarily disable it

J3fftw1 avatar Oct 07 '22 16:10 J3fftw1

Patience. This is an open-source project contributed to by volunteers.

On 10/7/22, J3fftw @.***> wrote:

You could temporarily disable it

-- Reply to this email directly or view it on GitHub: https://github.com/Slimefun/Slimefun4/issues/3664#issuecomment-1271827093 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

Phoenix-Starlight avatar Oct 08 '22 05:10 Phoenix-Starlight

Also you will not lose backpack data if you were to disable usage. The data will remain but no one can make backpacks or use them.

On 10/7/22, Nova Star @.***> wrote:

Patience. This is an open-source project contributed to by volunteers.

On 10/7/22, J3fftw @.***> wrote:

You could temporarily disable it

-- Reply to this email directly or view it on GitHub: https://github.com/Slimefun/Slimefun4/issues/3664#issuecomment-1271827093 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

Phoenix-Starlight avatar Oct 08 '22 05:10 Phoenix-Starlight

You could temporarily disable it

ok thanks and sorry

SrMonsterYT avatar Oct 08 '22 15:10 SrMonsterYT

I hope it is fixed now, haven't tested it yet. Let me know if the next build will have this issue fixed. I suspect the reason the previous fix wasn't working was due to a threading issue.

TheBusyBiscuit avatar Oct 18 '22 13:10 TheBusyBiscuit

Just tested in Slimefun 1035 and looks like it is fixed.

ybw0014 avatar Oct 18 '22 18:10 ybw0014