Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Higher level interact event cancellation to prevent flask of knowledge from able to fill up water

Open FN-FAL113 opened this issue 2 years ago • 0 comments

Description

Prevent flask of knowledge from able to fill up water which can turn the flask to a water bottle instead Since the event cancellation is only registered for the flask as an item handler, I don't see this specific cancellation to affect other items while right clicking

Proposed changes

  • Moved the cancel event method outside of the condition

Related Issues (if applicable)

  • Resolves #3524

Checklist

  • [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [ ] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

FN-FAL113 avatar Aug 05 '22 01:08 FN-FAL113