Bugfix Ancient Pedestal & Make Never Despawn

[JustAHuman-xD]

trafficstars

Description

To fix 2 bugs with the Ancient Pedestal and to allow people to use it to show off items

Proposed changes

I have made the Ancient Pedestal create a Armor stand, with slightly modified code to that of the Hologram Projector And set the Ancient Pedestal item to be a passenger of that Armor Stand, it stops it from being affected by both falling blocks and fluids. I have also made the Item have an Unlimited Lifetime, that way people don't have to worry about items despawning & can use the Ancient Pedestal to show off items! This will also make the pedestal not hopperable because it was not that way already.

Related Issues (if applicable)

Resolves #2940 Resolves #3147

Checklist

• [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
• [x] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
• [x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.14.* - 1.19.*).
• [x] I followed the existing code standards and didn't mess up the formatting.
• [x] I did my best to add documentation to any public classes or methods I added.
• [x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
• [x] I added sufficient Unit Tests to cover my code.

[JustAHuman-xD]

Is the only reason it disables a pedestal with a block above it because of the current issues? If so can I remove that? It would allow people to put these underwater or put glass blocks on top to get a proper display case feel.

[J3fftw1]

Is the only reason it disables a pedestal with a block above it because of the current issues? If so can I remove that? It would allow people to put these underwater or put glass blocks on top to get a proper display case feel.

Depends on the placement of the armor stand

[JustAHuman-xD]

Is the only reason it disables a pedestal with a block above it because of the current issues? If so can I remove that? It would allow people to put these underwater or put glass blocks on top to get a proper display case feel.

Depends on the placement of the armor stand

[J3fftw1]

Is the only reason it disables a pedestal with a block above it because of the current issues? If so can I remove that? It would allow people to put these underwater or put glass blocks on top to get a proper display case feel.

Depends on the placement of the armor stand

It seems like this is on the block level so nothing can be placed in that spot iirc. But you should just test it and see. Hard to know exactly armor stands are a bit weird

[JustAHuman-xD]

Is the only reason it disables a pedestal with a block above it because of the current issues? If so can I remove that? It would allow people to put these underwater or put glass blocks on top to get a proper display case feel.

Depends on the placement of the armor stand

It seems like this is on the block level so nothing can be placed in that spot iirc. But you should just test it and see. Hard to know exactly armor stands are a bit weird

Water can just flow ontop or get filled via water mechanics, and pistons can be used to push blocks ontop

[JustAHuman-xD]

Going to close this PR and re-write it, I wrote this early on while learning java so I'm sure there are some issues.