Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Replace `Validate` checks from `commons-lang` with `Preconditions` checks from Guava

Open TheBusyBiscuit opened this issue 2 years ago • 1 comments

See #3585 for context.

In MC 1.19 Spigot has removed commons-lang from its dependencies. We really shouldn't be shading this library just for this one feature and instead switch to what Spigot uses.

So any Validate.notNull(x, msg) will become Preconditions.checkNotNull(x, msg) and any Validate.isTrue(x, msg) shall become Preconditions.checkArgument(x, msg). It would be really helpful if somebody could make a pull request for this and remove commons-lang from our pom.xml.

TheBusyBiscuit avatar Jun 11 '22 10:06 TheBusyBiscuit

It seems like it's blocked by https://github.com/baked-libs/dough/pull/184 via https://github.com/Slimefun/Slimefun4/pull/3589

Haarolean avatar Oct 25 '23 15:10 Haarolean