Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Plugin Incompatibility - MMOitems

Open TheLaoming opened this issue 2 years ago • 3 comments

❗ Checklist

  • [X] I am using the official english version of Slimefun and did not modify the jar.
  • [X] I am using an up to date "DEV" (not "RC") version of Slimefun.
  • [X] I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • [X] I searched for similar open issues and could not find an existing bug report on this.

📍 Description

Hey there,

So about my problem, there are several problems with mmoitems but I don't care about them actually. The main problem I need to fix, is actually fact that players are able to enchant mmoitems witch blocked use in enchanting tables or anvils in sf autoenchanters. in. My items are blocked against enchanting but in sf you can simply bypass it. I know there's a way to add blocked lore. But what about old items without that lore? A lot of of my players using items without this lore.

So what I need to add ? Easily check stats from mmoitem and if it has blocked using in crafting, enchanting.., it won't be possible to upgrade this item. This will be probably better than using lores, because it will apply to all items no matter how old those items are.

Let me know, if it is possible, thanks and have a good day!

📑 Reproduction Steps

Create an mmoitem and block it's interaction in enchanting tables/anvils. Add this item to slimefun autoenchanter. You can add this item there.

💡 Expected Behavior

MMOItems with blocked features like using them in enchanting tables, they should not be usable in sf as well.

📷 Screenshots / Videos

caw caw

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Purpur

🎮 Minecraft Version

1.16.x

⭐ Slimefun version

DEV 955

🧭 Other plugins

MMOItems 6.6.0 Premium

TheLaoming avatar Aug 26 '21 10:08 TheLaoming

Since mmoItems is a premium plugin, we have no way to know how it's implemented and what the code is doing behind the scenes. I expect the dev to have some platform where support can be provided (discord or whatever), in which case you can send them this whole message and it should lead to a quick fix: I assume the dev uses some way to discern mmoItems from other items, most likely PDC data. If that is the case, they can add a simple listener to AutoEnchantEvent (src/main/java/io/github/thebusybiscuit/slimefun4/api/events/AutoEnchantEvent.java) and cancel it if the item is a mmoItem - this will make the AutoEnchanter unable to enchant stuff which should solve your issue

Sfiguz7 avatar Aug 26 '21 17:08 Sfiguz7

As said in the Discord in #slimefun-chat, I am reopening in the meantime since discussion was taking place there. It will be closed later on depending on how that goes

Sfiguz7 avatar Aug 26 '21 18:08 Sfiguz7

Hi, I think this issue should be reported to MMOItems. It is quite easy for them to implement new stats to block items being used in the Slimefun machines. Actually, I've implemented an addon for my server to do this.

pianwan avatar Aug 27 '21 03:08 pianwan