SlimeVR-Server
SlimeVR-Server copied to clipboard
SlimeVR
macOS app naming improvements
Sets "SlimeVR" as app name in multiple locations. In the future this could be replaced by displayName if tauri ever implement it.
The SlimeVR Server is not the GUI, and the app is specifically the GUI
Okay, but the windows installer installs a “SlimeVR Server” shortcut into start menu that launches the GUI, so I wonder why is it not appropriate here? It’s the name for the package that contains both GUI and server.
And we also have the linux desktop file which is just SlimeVR, we have the binary called slimevr.exe in Windows, and we have the macOS binary which is slimevr.app
I don't really know the reason for why it's called SlimeVR Server in the start menu but I suspect it's been like that since the start and having to change it seems like too much problem.
why are you signing the app
Do you not want that? I was just about to say I added that because without a signature users are probably going to have problems launching the app because macOS Gatekeeper is only getting stricter.
I mean, we don't have any signature to sign it with XD. Or does every macOS come with a user signature?
I mean, we don't have any signature to sign it with XD. Or does every macOS come with a user signature?
I signed with - identity which is local adhoc signature. It's not a developer identity but should be better than flat out no signature.
Also idealy version of the app bundle should match github releases, right now I believe it's inherting the GUI version. Do you want that to be overwritten in Info.plist as well?
then its fine to sign it.
the version stuff, it would be nice to fix the actual issue, the package.json of gui is not the same as the git tag and i don't really know how to fix it
the version stuff, it would be nice to fix the actual issue, the
package.jsonofguiis not the same as the git tag and i don't really know how to fix it
It's possible with npm version, but it's usually used to create/manage git tags, not the other way around (following existing git tags). I'm experimenting with it now, there should be a way around.
I kinda figured it out. Workflows triggered by releases will have their version in gui/packages.json corrected ~~but that will also make the build dirty. To truely get around this I guess you really need to use npm version the way it meant to be used~~.
Edit: I think I have a near perfect solution now. No dirty builds anymore.