SlimeVR-Rust icon indicating copy to clipboard operation
SlimeVR-Rust copied to clipboard
verified publisher icon SlimeVR

Add ISM330DHCX

Open Noxime opened this issue 2 years ago • 4 comments

Probably applicable for other ST micro's IMUs #154

Noxime avatar Jan 25 '23 21:01 Noxime

I've not seen this chip before. Do you have one you are using to test?

TheButlah avatar Jan 25 '23 21:01 TheButlah

If you don't even have the chip in hand, and didn't even run the code, and its a random IMU I've never anyone talk about in discord, I don't understand why you opened a PR. Marking as a draft until someone can test this on hardware.

TheButlah avatar Jan 26 '23 09:01 TheButlah

I'm going to assume that you acted in good faith and were not trying to spam PRs to prove a point. I'll be drafting up a clarification in the contributing.md making more clear what the bar is for merge. Hopefully that will help avoid these shenanigans in the future.

TheButlah avatar Jan 26 '23 11:01 TheButlah

This is definitely a petty shenanigan. However, this PR has been tested and verified against a drop-in compatible LSM6DS3TR

Noxime avatar Jan 26 '23 16:01 Noxime