SlicerGitSVNArchive icon indicating copy to clipboard operation
SlicerGitSVNArchive copied to clipboard

Plenty chinese i18n ts files and code modification

Open u8621011 opened this issue 7 years ago • 4 comments
trafficstars

Below is what this PR includes

  1. traditional/simplified Chinese translation files
  2. i18n related cmake script for loadable module
  3. i18n related code fixes.

u8621011 avatar Feb 23 '18 06:02 u8621011

I haven't reviewed in detail, but in principle this looks great!

I'd be mostly concerned about unintended side effects, so maybe we could find a way to generate to packages from this branch that people can test thoroughly.

pieper avatar Feb 23 '18 13:02 pieper

I rebased and re-organize the changes.

I will add comment directly on each commit

jcfr avatar Feb 23 '18 19:02 jcfr

A lot of the changes have been reviewed, fixed and integrated. Including support for Qt5.

Remaining changes to review are the one in this PR

jcfr avatar Feb 23 '18 22:02 jcfr

Few runtime issues:

  • failed to initialize the dataprobe module: No Data Probe frame - cannot create DataProbe
  • And few file that failed to be loaded in the translator:
The File  "qSlicerBaseQTCore_zh_cn.qm"  hasn't been loaded in the translator
The File  "qSlicerBaseQTApp_zh_cn.qm"  hasn't been loaded in the translator
The File  "SubjectHierarchy_zh_cn.qm"  hasn't been loaded in the translator
The File  "VolumeRendering_zh_tw.qm"  hasn't been loaded in the translator

Few more things we need to address:

  • CLI module translation:
    • I envision that we would distribute a file named like <modulename>_zh_cn.qm.ts. We should then update https://github.com/Slicer/SlicerExecutionModel to ensure the logic generating and installing the translation files is used by the macro SEMMacroBuildCLI
  • distribution of *.qm files within Slicer extension
  • translation of text from vtk and mrml objects. I suggest to investigate the use of QT_TRANSLATE_NOOP

Otherwise, I was able to start Slicer built with Qt5:

slicer-i18n

jcfr avatar Feb 24 '18 00:02 jcfr