SlicerExecutionModel icon indicating copy to clipboard operation
SlicerExecutionModel copied to clipboard

KWSys / itksys no longer has a SharedForward.h.in file

Open aylward opened this issue 1 year ago • 3 comments
trafficstars

ITK has updated its version of KWSys (the source of itksys).

https://github.com/InsightSoftwareConsortium/ITK/commit/2c45eec4b39cd8b2a0a1b0dc2a6e4182b73bd91f

That update introduced a version of KWSys that does not contain the SharedForward.h.in file, as required by GenerateCLPLauncher.

https://github.com/Slicer/SlicerExecutionModel/blob/bd2efa9e70900483e6c26a54d7108d97bf36f740/GenerateCLP/GenerateCLPLauncher.c.in#L19

SlicerExecutionModel (specifically the GenerateCLPLauncher) will not compile with ITK master.

aylward avatar Apr 26 '24 16:04 aylward

I noticed this too and spoke with @jcfr about it. He indicated it won't be hard for him to address when Slicer's ITK is updated.

pieper avatar Apr 26 '24 17:04 pieper

In the meantime, copying the removed file into src and adding it as a _h file to be configured, in the cmakelists.txt file, works.

aylward avatar Apr 26 '24 17:04 aylward

Ditto. That is indeed the plan 🚀👌

jcfr avatar Apr 28 '24 13:04 jcfr

In the meantime, copying the removed file into src and adding it as a _h file to be configured, in the cmakelists.txt file, works.

I am giving this a try.

dzenanz avatar May 30 '24 16:05 dzenanz