Slicer icon indicating copy to clipboard operation
Slicer copied to clipboard
verified publisher icon Slicer

Improve apperance of of slice view controller

Open lassoan opened this issue 2 years ago • 5 comments

The pull request that removed some styling from the slice view controllers (https://github.com/Slicer/Slicer/pull/7219) introduced some cosmetic/usability issues:

  • white-on-yellow text in the yellow's slice controller
  • blurry push-pin icon (the icon might have been low-resolution before, but it was not this big, so it was not that noticeable)

image

lassoan avatar Sep 18 '23 12:09 lassoan

white-on-yellow text in the yellow's slice controller

Is this specifically Slicer Dark style? I have a memory of everything being dark text but I’m typically using Slicer light style.

jamesobutler avatar Sep 18 '23 12:09 jamesobutler

Yes, the default dark style.

lassoan avatar Sep 18 '23 14:09 lassoan

@lassoan I can't really tell that the PushPin looks any blurrier than the original PNG file when I view them side-by-side. Maybe the blurriness you are seeing is the same as what is inherently in the PNG file?

  • PushPinIn.png (32x32px) https://github.com/Slicer/Slicer/blob/c721e9c647b4f97243ede001674f4e0b7756b5b0/Libs/MRML/Widgets/Resources/Icons/PushPinIn.png
  • PushPinOut.png (32x32px) https://github.com/Slicer/Slicer/blob/c721e9c647b4f97243ede001674f4e0b7756b5b0/Libs/MRML/Widgets/Resources/Icons/PushPinOut.png

I'm not sure what I could do if it the issue is inherently in the original source file. I could swap it out for the Material Symbol's Push Pin SVG. image

Is it only the PushPin icons that look blurry? Or do any of the other icons in the Slice view controller look blurry to you?

  • SlicesFitToWindow.png (19x19px) https://github.com/Slicer/Slicer/blob/c721e9c647b4f97243ede001674f4e0b7756b5b0/Libs/MRML/Widgets/Resources/Icons/SlicesFitToWindow.png
  • ViewMaximize.png (19x19px) https://github.com/Slicer/Slicer/blob/c721e9c647b4f97243ede001674f4e0b7756b5b0/Libs/MRML/Widgets/Resources/Icons/ViewMaximize.png
  • ViewRestore.png (19x19px) https://github.com/Slicer/Slicer/blob/c721e9c647b4f97243ede001674f4e0b7756b5b0/Libs/MRML/Widgets/Resources/Icons/ViewRestore.png

jamesobutler avatar Sep 18 '23 21:09 jamesobutler

The pushpin icon did not look nice before but since it is bigger now, the low quality has become more noticeable. All the other icons in the slice view controller are good, only the pushpin icon looks bad (probably because the other icons don't have any curved lines, so they scale perfectly). We already have a number of SVGs coming from the material icon set and they appear nicely at various resolutions, so hopefully the SVG icon will work well here, too.

lassoan avatar Sep 18 '23 22:09 lassoan

@jamesobutler @lassoan I re-targeted this to Slicer 5.11 and I anticipate it will be addressed while finalizing:

  • https://github.com/Slicer/Slicer/pull/5887

cc: @sjh26

jcfr avatar Sep 12 '25 12:09 jcfr