ExtensionsIndex
ExtensionsIndex copied to clipboard
Add DeepLearningUI extension
New extension
- [x] Extension has a reasonable name (not too general, not too narrow, suggests what the extension is for)
- [x] Repository name is Slicer+ExtensionName
- [x] Repository is associated with
3d-slicer-extensionGitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter3d-slicer-extensionin "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topics - [x] Extension description summarizes in 1-2 sentences what the extension is usable (should be understandable for non-experts)
- [x] Any known related patents must be mentioned in the extension description.
- [x] If source code license is more restrictive for users than BSD, MIT, Apache, or 3D Slicer license then the name of the used license must be mentioned in the extension description.
- [x] Extension URL and revision (scmurl, scmrevision) is correct, consider using a branch name (main, master, release, ...) instead of a specific git has to avoid re-submitting pull request whenever the extension is updated
- [x] Extension icon URL is correct (do not use the icon's webpage but the raw data download URL that you get from the download button - it should look something like this: https://raw.githubusercontent.com/user/repo/main/SomeIcon.png)
- [x] Screenshot URLs (screenshoturls) are correct, contains at least one
- [x] Homepage URL points to valid webpage containing the following:
- [x] Extension name
- [x] Short description: 1-2 sentences, which summarizes what the extension is usable for
- [x] At least one nice, informative image, that illustrates what the extension can do. It may be a screenshot.
- [x] Description of contained modules: at one sentence for each module
- [x] Tutorial: step-by-step description of at least the most typical use case, include a few screenshots, provide download links to sample input data set
- [x] Publication: link to publication and/or to PubMed reference (if available)
- [x] License: We suggest you use a permissive license that includes patent and contribution clauses. This will help protect developers and ensure the code remains freely available. We suggest you use the Slicer License or the Apache 2.0. Always mention in your README file the license you have chosen. If you choose a different license, explain why to the extension maintainers. Depending on the license we may not be able to host your work. Read here to learn more about licenses.
- [x] Content of submitted s4ext file is consistent with the top-level CMakeLists.txt file in the repository (description, URLs, dependencies, etc. are the same)
This is interesting and I'm glad you were able to implement it, but I have some questions that were unclear from the readme. First, how is one expected to generate the training data and why is it jpeg? Is there a repository of example training data? Second, how does on use the resulting model? Can you apply it to new data loaded in Slicer?
Great questions. I am currently working on making the data generation process easier by designing another module that will be added to the same extension. The same goes for prediction. So There will be three modules in this extension: 1. Data preparation, 2. Training, 3. Testing. Among which only Training part is done.
Sounds good, looking forward to seeing it 👍
It probably makes sense to wait for the complete workflow before merging this and then posting on discourse with an example video or tutorial.
@Connor-Bowley Will you have a look?
Yes I will take a look at your extension.
I have added some issues into your extensions git repo that should probably be addressed before merging this.
- https://github.com/mturja-vf-ic-bd/SlicerDeepLearningUI/issues/1
- https://github.com/mturja-vf-ic-bd/SlicerDeepLearningUI/issues/2
- https://github.com/mturja-vf-ic-bd/SlicerDeepLearningUI/issues/3
- https://github.com/mturja-vf-ic-bd/SlicerDeepLearningUI/issues/4
@Connor-Bowley Thanks for the help reviewing :pray:
@mturja-vf-ic-bd After reviewing the suggestions linked above, let us know if you have any questions.
@Connor-Bowley I have addressed your additional comments.
@mturja-vf-ic-bd The extension is looking good. There are a few checkbox items you still need to address (e.g. the license)
The checkbox items are addressed.
The icon URL is incorrect. It should be https://raw.githubusercontent.com/mturja-vf-ic-bd/SlicerDeepLearningUI/main/DeepLearningUI.png
Similarly the screenshot URL should be https://raw.githubusercontent.com/mturja-vf-ic-bd/SlicerDeepLearningUI/main/screenshot.png
One way to get the URL on Chrome is to go to the file in github, right-click on the image, and do "Open image in new tab". That should open the image where you can grab the correct link.
Before we can more forward with the integration, I suggest you review and address the following issues:
- https://github.com/mturja-vf-ic-bd/SlicerDeepLearningUI/issues/6
- https://github.com/mturja-vf-ic-bd/SlicerDeepLearningUI/issues/7
- https://github.com/mturja-vf-ic-bd/SlicerDeepLearningUI/issues/8
- https://github.com/mturja-vf-ic-bd/SlicerDeepLearningUI/issues/9
- https://github.com/mturja-vf-ic-bd/SlicerDeepLearningUI/issues/29