EnderIO
EnderIO copied to clipboard
Reduce Memory pressure of UpgradePath
Hi there, I did some memory analysis on large modpacks, trying to reduce the memory pressure. I noticed that the HashMap in your DarkSteelUpgradeRecipeCategory is taking up around 150MB of heap space. If you look at the objects inside the map that take, you find that 45MB of the 150MB are just char arrays. This is because the String id can grow quite huge. My solution is to simply remove the id, and cache the hashcode instead. The equals check should not be much slower, as it fails fast for different input items
The result is that DarkSteelRecipeManager uses around 45MB less memory.
Some screenshots from eclipse MAT:
Without my changes:
With the changes in this PR: