TameMyCerts.REST icon indicating copy to clipboard operation
TameMyCerts.REST copied to clipboard

Published 20 hours ago • verified publisher icon Sleepw4lker

Just a few questions and enhancements for your REST API

Open ajdergute opened this issue 6 months ago • 1 comments

This is a very clean API. Good job! Just a few thoughts from my side:

  1. In general it could be an idea to pass information for encodings via header, not query parameter. This could be done via Content-Type- and Accept-Headers. Maybe a custom type should be added.

  2. requestAttributes: https://github.com/Sleepw4lker/TameMyCerts.REST/blob/7c13c429bce37d316b0764dd300a3140d3f79478/TameMyCerts.REST.xml#L42 As a user I've no clue which optional attributes are allowed.

  3. TimeSpan: https://github.com/Sleepw4lker/TameMyCerts.REST/blob/7c13c429bce37d316b0764dd300a3140d3f79478/TameMyCerts.REST.xml#L837 In Swagger-UI this is rendered as TimeSpan. This is implementation specific. At level of API this should be a date formatted as ISO 8601 or similar.

  4. What's the difference between a certificate authority certificate and it's exchange certificate?

ajdergute avatar Dec 20 '23 20:12 ajdergute