Vyacheslav Kovalevsky

Results 43 comments of Vyacheslav Kovalevsky

Coverage for deploy now seems to be tracked. ![image](https://github.com/user-attachments/assets/9f1ac954-6fee-4e90-8831-37140560fe47) There are minor issues with coverage blocks overlapping, though on right (in vscode) you can see red blocks even when overlapped,...

figuring out why tests are failing

Should be fixed. (for some reason `flag.VisitAll` included `coverProfile` flag with value `""`, even when coverage is not enabled in `go test`)

It seems like there are issues with CI coverage, because neotest replaces original coverage data.

![image](https://github.com/user-attachments/assets/c56cb7f9-0856-4cfb-b2c4-8a8abe046b28) maybe we should use some ENV variable that disables neotest coverage and use it in CI

> ![image](https://private-user-images.githubusercontent.com/40753025/358506566-c56cb7f9-0856-4cfb-b2c4-8a8abe046b28.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM3OTQ1NTcsIm5iZiI6MTcyMzc5NDI1NywicGF0aCI6Ii80MDc1MzAyNS8zNTg1MDY1NjYtYzU2Y2I3ZjktMDg1Ni00Y2ZiLWIyYzQtOGE4YWJlMDQ2YjI4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE2VDA3NDQxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE5YzdiZTBkNDE3Y2UwMzZiZWU0MTZkN2RlMTUwMTZkODkxMDBjZjkyZjA4ZDQ2NDE5OWZkOTk0MDFiOTE4ZWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.zmxbqHVSSPzrooThB50N-kMRKXqRYeHoGQJhOplaT1s) maybe we should use some ENV variable that disables neotest coverage and use it in CI or having a flag would be better?

Naming gets really bad with coverage package, we now have 3 different flags that enable/disable coverage `coverageEnabled`, `isDisabled` + `collectCoverage` in Executor.

do we need this after #18638 merge?

I looked at this closer and it seems like SeqPoints can overlap sometimes (usually one can cover entire function), is this intended?

I guess we would have to actually use AST and maybe keep extra info from codegen