tern-meteor icon indicating copy to clipboard operation
tern-meteor copied to clipboard

meteor plugin as installed package. See http://ternjs.net/doc/manual.html#plugin_third_party

Open angelozerr opened this issue 10 years ago • 9 comments

This PR gives you the capability to avoid setting meteor.js inside tern/plugin folder but setting tern-meteor folder inside your node_modules. More once you will publish tern-meteor with npm publish, you will able to install it with npm install. See http://ternjs.net/doc/manual.html#plugin_third_party for explanation how tern loads tern plugin.

angelozerr avatar Oct 30 '14 16:10 angelozerr

@Slava if you wish some more explanation about my (very simple) patch, don't hesitate to tell me. I need this patch to integrate tern-meteor inside tern.java (see https://github.com/angelozerr/tern.java/wiki/Tern-&-Meteor-support) with clean mean (not inside tern/plugin but inside node_modules/tern-meteor folder)

Thank's!

angelozerr avatar Nov 01 '14 16:11 angelozerr

I didn't see it, sorry.

Some explanation on how it is supposed to work and updated installation docs (they change if we publish this as npm module, right?) would be great.

Slava avatar Nov 01 '14 17:11 Slava

At first, with my patch you can publish tern-meteor with npm publish.

Today you must copy/paste at hand the meteor.js inside the tern/plugin folder, with my patch you can use npm install. Here steps :

  • create an empty TernJS folder.
  • cd TernJS
  • npm install tern to download tern. After that your TernJS folder will contains node_modules/tern
  • cd TernJS/node_modules/tern
  • npm install tern-meteor to download tern meteor. After that your TernJS/node_modules/tern folder will have a new folder node_modules/tern-meteor

And that's all!

To use npm install tern-meteor you will have to publish tern-meteor (with npm punblish).

My patch should not break the existing installation (you will able to copy/paste meteor.js inside tern/plugin if you wish).

angelozerr avatar Nov 01 '14 22:11 angelozerr

I suggest you do it yourself and then give me access to the npm module you publish so I can update in future in case you are not around. I am not ready to merge things I don't understand and I don't have time to read up about this so far.

Slava avatar Nov 02 '14 04:11 Slava

I am not ready to merge things I don't understand and I don't have time to read up about this so far.

that's shame-(

Other tern plugin does that. For instance foogle closure provides that. You can read installation guide of tern-closure at https://github.com/google/tern-closure#short-version

angelozerr avatar Nov 02 '14 12:11 angelozerr

@Slava if you decide not to accept this PR, could you just accept please only this update https://github.com/Slava/tern-meteor/pull/17/files#diff-0e3c470f571980d185893bb3b30a4164R3

This update works when meteor.js is inside tern/plugin (like today) and will work when tern plugin is outside tern/plugin (inside tern-meteor foldr with a package.json).

Thank's!

angelozerr avatar Nov 03 '14 08:11 angelozerr

+1

This PR is trivial enough. If @Slava isn't inclined, though, I would agree that you ( @angelozerr ) should just publish tern-meteor to NPM yourself. Just fork and publish.

Worst case, if you don't want to do it, I'll be happy to do so.

Ulexus avatar Sep 29 '15 22:09 Ulexus

IMHO, I think it should be better that @Slava publish it, because he knows when tern-meteor can be released.

angelozerr avatar Sep 30 '15 00:09 angelozerr

I would not disagree; on the other hand, it's been a year.

Ulexus avatar Sep 30 '15 00:09 Ulexus