Slashgear
Rerunning still fails
Describe the bug Note: This might be an issue that is intrinsic to the feature, and makes perfect sense, if so, please do ignore me.
If I ever re-run this job, even after changing the title, it still uses the same title as it had before. This is a bit annoying, since without running the rest of the suite (which happens to be another ci tool outside of github), even if one edits the title 5 seconds later, any re-run will be based on the pre-existing title.
To Reproduce Steps to reproduce the behavior:
- Go to a project that has this action setup.
- Add a title on the PR stage, realise you've made a typo or something.
- See this build failing very quickly
- Make a change to the title, attempt to re-run the job, and it still fails.
Expected behavior I expect that when rerun the job, it's going to know about the pull request title that I can see vs having to push a new commit in.
Screenshots If applicable, add screenshots to help explain your problem.
Additional context This is using version 4.3.0, the current tagged version, which outside of
Hmm, looking at the node_modules/.pnpm/@[email protected]/node_modules/@actions/github/lib/context.js when checking this out locally, looks pretty conclusively like it's very much a specific SHA, so a re-run won't fix it since it's the same commit message as it looks at the webhook object.
Leaving this open in case someone else has a good idea on how to implement this.
Edit: Since the SHA is what sends the title, without changing to using a dockerfile approach, it's something where another commit is required. Often not a problem since folk should just add to their PR template what titles are acceptable + at some point after an edit a rebase/merge/"fix" commit will follow.
Feel free to close if this isn't a path to go down.
Yes of course, user will often rework a commit / rebase or merge so i may not be that annoying
