react-linky icon indicating copy to clipboard operation
react-linky copied to clipboard

rel="noopener noreferrer"

Open cabello opened this issue 5 years ago • 1 comments

Hi 👋

Thank you for sharing your project with the world, I found your project at https://ui.dev/newsletters/react/236/

I am currently using https://www.npmjs.com/package/linkifyjs the React part is about ~10kb.

One thing I add to potentially external links is rel="noopener noreferrer" check it out: https://clever-solution.com/blog/everything-you-need-to-know-about-rel-noopener-noreferrer-tags-purpose-benefits-and-seo-impact

Do you think you could make that a prop available for Linky?

On a separate question likely better suited for another issue, did you have a chance to do performance tests? Like rendering 1k Linky components in one page and seeing how it performs?

Thank you again, cheers 💜

cabello avatar Oct 31 '20 01:10 cabello

Hi Danilo Thank you for your idea and for your help. I'll add a prop for "noopener" and "noreferrer" in next the next release. For the second question, I have a new idea for implementation and after adding unit tests and new implementation I'll add performance tests.

SlashArash avatar Nov 01 '20 11:11 SlashArash