Filippo Tessarotto comments

Results 335 comments of


                                            Filippo Tessarotto

Notice undefined property in Attachment::getEmbeddedMessage()

Exactly, I need it to replicate the behavior in the test suite

Notice undefined property in Attachment::getEmbeddedMessage()

As I said, just strip any sensitive data: 1. Each IP/DNS or domain can be set to 1.1.1.1/example.com 2. Each name can be John Doe 3. Each attachment content can...

Notice undefined property in Attachment::getEmbeddedMessage()

`$message->getRawMessage()`

Notice undefined property in Attachment::getEmbeddedMessage()

I need time to debug it, hope to have a look in the next month

Notice undefined property in Attachment::getEmbeddedMessage()

I don't think you can escape it. Any PR is welcome

MailboxIterface: Typehint to interface instead of implementation

Nice, could you also update `Mailbox` as well please?

MailboxIterface: Typehint to interface instead of implementation

The issue is that `ArrayIterator::getArrayCopy` is not part of any interface. Now I remember this is the reason why I type-hinted against `MessageIterator` and not `MessageIteratorInteface`. I see no solution...

MailboxIterface: Typehint to interface instead of implementation

That wouldn't respect proper type covariance in type hints. We should set `MessageIteratorInterface` to extend `Traversable` interface, to we can easily use `iterator_to_array` as you suggest

Cuttet FileName

Ok. This is not the first time I see different implementations of IMAP protocol. Unfortunately I have no solution for this kind of issues.

Message::getHeaders() does not parse message ID correctly

Partial duplicate of https://github.com/ddeboer/imap/issues/385 We know the issue, but the performance impact of `imap_fetchheader` is huge. A solution is still under research