Filippo Tessarotto comments

Results 335 comments of


                                            Filippo Tessarotto

Issue: FASTQC Process Fails with Exit Code 140 in nf-core/sarek Pipeline Using Singularity

Hello, thank you for your sponsorship and the time you took to improve this library. I researched the topic a bit more and I found that the `` attribute in...

Fix 321 - scientific notation reading causes InvalidValueException error

Thank you for the contriution but we need some tests to be sure the bug doesn't get introduced anymore in the future

Number formatted in scientific notation causes InvalidValueException

Somehow this `if` returns `true`: https://github.com/openspout/openspout/blob/f0c2b94e744b8c9ab28a2df753d03a2682d4f700/src/Reader/XLSX/Helper/CellValueFormatter.php#L199 Any help is welcome

Dummy functions for logic only relevant to one type of writer

That would be so consufing, we would have people asking "Why are there methods that don't do anything?" I suggest you to keep do the `if` conditioning

Add an XLSX option to disable auto create first sheet.

> So, may you add an option to make this code more beautiful? Can you?

Add textRotation to cell style

Hi, can you add a test please?

Add textRotation to cell style

Thank you

Issues with extending final functions and strict types

Sorry for the late reply. As far as I can tell, there is currently only one blocking piece that prevent a proper extension of the code, which is the `\OpenSpout\Writer\AbstractWriter::addRow`...

Issues with extending final functions and strict types

Any PR that extends teh usability and functionality of the library without deleting strictness and good OOP is very welcome

Http(s) support for open file

Any PR is welcome, although I suggest to just download the file locally first, and then proceed to analyse it