backpack icon indicating copy to clipboard operation
backpack copied to clipboard

[NO JIRA][BpkCardList]Fix A11y translation issues

Open senzg opened this issue 6 months ago • 2 comments

Fix an A11y issue, remove hardcoded aria-label: https://skyscanner.slack.com/archives/C04FCMBSZLK/p1750931849361789

Remember to include the following changes:

  • [ ] Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • [x] README.md (If you have created a new component)
  • [ ] Component README.md
  • [x] Tests
  • [x] Accessibility tests
    • The following checks were performed:
      • [ ] Ability to navigate using a keyboard only
      • [ ] Zoom functionality (Deque University explanation):
        • [ ] The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • [ ] Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • [ ] Ability to navigate using a screen reader only
  • [ ] Storybook examples created/updated
  • [ ] For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

senzg avatar Jun 27 '25 05:06 senzg

Visit https://backpack.github.io/storybook-prs/3861 to see this build running in a browser.

Warnings
:warning:

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by :no_entry_sign: dangerJS against 340be8128abf3af2764f1e76cd66f2f7259d7152