backpack icon indicating copy to clipboard operation
backpack copied to clipboard

[WIP][Clover GF][BpkTooltip]The max-width of BpkTooltip can be Customized

Open senzg opened this issue 8 months ago • 4 comments

We can customize the max width of the inner div as the example here:

ontréal-Trudeau International Airport Testing long text Testing

ariaLabel=Montréal-Trudeau International

Remember to include the following changes:

  • [ ] Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • [ ] README.md (If you have created a new component)
  • [ ] Component README.md
  • [ ] Tests
  • [x] Accessibility tests
    • The following checks were performed:
      • [x] Ability to navigate using a keyboard only
      • [x] Zoom functionality (Deque University explanation):
        • [x] The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • [x] Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • [x] Ability to navigate using a screen reader only
  • [x] Storybook examples created/updated
  • [x] For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

senzg avatar Apr 14 '25 07:04 senzg

Visit https://backpack.github.io/storybook-prs/3800 to see this build running in a browser.

Warnings
:warning:

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

:warning:

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by :no_entry_sign: dangerJS against c3f80e99a041af4417973589df0822b59b870c3e

Visit https://backpack.github.io/storybook-prs/3800 to see this build running in a browser.

Here I would expect the content that is passed into the BpkTooltip to control the width of the tooltip as the component is just a dumb container that should react to the content

olliecurtis avatar Apr 15 '25 08:04 olliecurtis