Skyrat13 icon indicating copy to clipboard operation
Skyrat13 copied to clipboard

(TM ONLY)(FUCK)Blob is gone :crab:

Open Yawet330 opened this issue 4 years ago • 11 comments

About The Pull Request

Disables blobs properly

Why its good for the game.

I hate blobs and xyel asked me to. Also because previous fix doesnt work :honk:

Changelog

:cl: fix: Properly disables blob. /:cl:

Yawet330 avatar Aug 26 '20 00:08 Yawet330

failed travis and we already have a PR that has disabled blob.

this pr is quite unnecessary and isnt following format.

jjpark-kb avatar Aug 26 '20 00:08 jjpark-kb

blob isn't disabled though, btw blob should be fixed not disabled. just revert the continous blob buffing that people seem to have had a fetish for.

N0B0DY-1MP0R7AN7 avatar Aug 26 '20 01:08 N0B0DY-1MP0R7AN7

im a dumbass and forgot to edit admin things hjonk

Yawet330 avatar Aug 26 '20 01:08 Yawet330

failed travis and we already have a PR that has disabled blob.

this pr is quite unnecessary and isnt following format.

This literally doesnt work. (in reference to the other PR)

Yawet330 avatar Aug 26 '20 01:08 Yawet330

The PR that disabled blob took the lazy way out and just set it to max threat. This doesn't disable blob, this just makes it so blob sets threat to 0 when it happens.

CoreFlare avatar Aug 26 '20 01:08 CoreFlare

The PR that disabled blob took the lazy way out and just set it to max threat. This doesn't disable blob, this just makes it so blob sets threat to 0 when it happens.

what lmao this PR literally fulldisables blob via commenting out, your looking for the other PR

Yawet330 avatar Aug 26 '20 01:08 Yawet330

When I said "this" I meant the PR that "disabled" blob.

CoreFlare avatar Aug 26 '20 01:08 CoreFlare

The other PR doesn't work because Dynamic has no respect for configurations.

Gandalf2k15 avatar Aug 26 '20 01:08 Gandalf2k15

When I said "this" I meant the PR that "disabled" blob.

The -9999 threat one isn't from the PR, as I told you before. That's from a config change, and we disabled it in config but that didn't work. So, we tried to change the numbers and weights to discourage it which is what you're referring to. The actual PR you're referring to actually changes the max occurrence for the events that happen outside of dynamic mode.

hugmeorelse avatar Aug 26 '20 03:08 hugmeorelse

The PR that disabled blob took the lazy way out and just set it to max threat. This doesn't disable blob, this just makes it so blob sets threat to 0 when it happens.

Changing to a higher threat isn't really "taking the lazy way out", it should be the way it's done normally. However, there are numerous bugs in the version of dynamic we're using, and none of our devs has gotten around to fixing it yet. Sadly to disable things we need to do full commentouts for now.

Akrilla avatar Aug 28 '20 20:08 Akrilla