Skyrat-tg icon indicating copy to clipboard operation
Skyrat-tg copied to clipboard

[TM READY] Liquid QoL and bugfix PR

Open Majkl-J opened this issue 10 months ago • 3 comments

About The Pull Request

Adds new cleaning methods for liquids, namely cellulose cleaning out small puddles, inspired by the real world vomit cleaning kits, which use sawdust. Scrubbing (The cleaning flag, not scrubbers) also cleans liquid puddles, this might need further testing and adjusting to see how to make this work correctly.

Cellullose has now been added to cleaner foam nades. The effect was not added to space cleaner as it would make it too easy to just fight with regular janitor tools like the spray.

Speeds up mop usage by a bit

  • [x] Add extra cleaning methods to liquid puddles
  • [ ] Test all types of scrubbing to see whether to actually add it or not
  • [x] Make the mop not a pain in the ass to use by speeding it up
  • [x] IMPORTANT: Figure out how to correctly add cellulose to the foam grenades by looking at the math
  • [x] Fix the runtime with empty liquid turfs being created upon reactions
  • [ ] Make fighting turf fires actually worth extinguishing
  • [ ] (Optional) Fix liquids in multi-z

How This Contributes To The Skyrat Roleplay Experience

Fixes bugs and makes liquids not ruin the janitor's day when the entirety of the kitchen gets flooded because the tank of cooking oil exploded.

Proof of Testing

TBD

Screenshots/Videos

Changelog

:cl: add: Scrubbing tools and cellulose now clean puddles qol: The mop is now faster at cleaning puddles, making it not as fiddly to use fix: fixes runtime with empty liquid pools code: Minor improvements of overall liquid code, with more comments and less single letter vars /:cl:

Majkl-J avatar Apr 04 '24 11:04 Majkl-J

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

github-actions[bot] avatar Apr 14 '24 01:04 github-actions[bot]

Hear me out, what if we added Liquid Pumps to all maps or make it a cargo buyable item. Currently it is also classed as a structure and not an actual machine. So that will probably need to be refactored. Liquid pump only sucks liquid of the tile it is on top.

SpaceLoveSs13 avatar May 02 '24 05:05 SpaceLoveSs13

I'm sorry for taking a while on this there are a lot of other issues that needed resolving and are frankly more critical than this

Majkl-J avatar May 02 '24 12:05 Majkl-J