Skyrat-tg icon indicating copy to clipboard operation
Skyrat-tg copied to clipboard

[Semi-Modular] Ports directional meteors/early warning from oldbase

Open OrionTheFox opened this issue 2 years ago • 2 comments

About The Pull Request

This was- Easier than I expected actually. Most of the code is just copied from TG's because overriding is better than risking sending meteors twice.

Also, turns out meteor code hasn't been touched in 7 years. So the changes from Cit still work almost exactly the same here.

Notes to Address:

  • [ ] I want to add a second announcement when meteors actually are going to start spawning. Need advice on how to do it - should I just add a timer at the end of the announce proc for like 5 seconds before spawns, that calls a second announcement?
  • [ ] Timer itself seems off by about 20 seconds extra. I don't know how the math there works, someone help ;-;

How This Contributes To The Skyrat Roleplay Experience

Simply put: random warningless destruction is kind of crummy for everyone.

"But engineers need something to do!!" This can and should be solved without smashing the entire station's round and freezing/suffocating them.

A warning combined with a rough direction to focus on gives engineers something new to do: the better they can prepare and brace, the less damage they'll need to properly fix. Crew as well can both help prep, and clear the targeted areas - meaning they can actually avoid a fully depressurized station and rather get maybe one department depressurized

TL;DR giving people time to brace for impact both means less spontaneous destruction, and preparation can be a reward in and of itself by preventing damage

Proof of Testing

Screenshots/Videos I made a really funny (and rushed) video for this but can't post it when git has a 10MB file limit (its 50 lmao whoops), posted in main-chat:

Here

Let this screenshot serve as the 'I dont want to look at the video' evidence:

image Tested with normal/catastrophic, only came from 1 side. Also tested Stray Meteor, and it's not affected by the timer 😎 still have a chance of one single meteor wiping out a spacewalker!

Changelog

:cl: add: Nanotrasen has updated their Early Warning system massively, giving the station a valuable minute or two to prepare before meteors, as well as ensuring the station is only hit from one direction! Be wary though, meteors can still come in at sharp angles and hit fairly deep, or teleport via bluespace! /:cl:

OrionTheFox avatar Oct 25 '22 11:10 OrionTheFox

basedorion

zased.... so.... fvcking.... zased...

press-mark avatar Oct 25 '22 11:10 press-mark

Hopefully we can get working meteor shield satellites too! Currently they don't actually do anything.

Acer202 avatar Oct 25 '22 19:10 Acer202

I hate how many huge sections of code copy-pasted from /tg/ folders to our own that we have and I don't really want to add more. This can surely be modularised better. I don't think there's really a risk of double meteors anyways.

I'll try some less copypaste ones later yea; not as used to coding so I went the easy route until reviews could tell me how they'd prefer it

OrionTheFox avatar Oct 29 '22 23:10 OrionTheFox

basedorion

zased.... so.... fvcking.... zased...

honestly dont wanna finish this PR because it means I dont see this lovely image any more.,.. it keeps me up at night. not out of fear, but out of pride. for i know i am good. i know they care. they love me! they love me!

OrionTheFox avatar Nov 29 '22 10:11 OrionTheFox

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

github-actions[bot] avatar Dec 09 '22 00:12 github-actions[bot]

TG is messing with dir stuff and I can't be assed so 🤷

OrionTheFox avatar Dec 09 '22 22:12 OrionTheFox