Skyrat-tg icon indicating copy to clipboard operation
Skyrat-tg copied to clipboard

GoofSec Update: Renames Bouncer to Service Guard

Open Iamgoofball opened this issue 2 years ago • 4 comments

About The Pull Request

Renames Bouncer to Service Guard. Bouncer is still available as an alternative title.

How This Contributes To The Skyrat Roleplay Experience

I wanted to do this early on, but was reluctant to due to issues with jobcode and jobbans. However, jobcode safely accepts job name changes now, so we can do this now.

This'll reduce the level of confusion Service Guards experience in determining "where do I protect?", knowing that their jurisdiction extends to the entire service department(and includes answering to the HoP).

Proof of Testing

yeah I'll do this in a few minutes if my wifi adapter stops shitting out every time I pull from master

Changelog

:cl: spellcheck: Renames Bouncer to Service Guard /:cl:

Iamgoofball avatar Oct 23 '22 08:10 Iamgoofball

You currently have a negative Fix/Feature pull request delta of -48. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

github-actions[bot] avatar Oct 23 '22 08:10 github-actions[bot]

I can just integrate this into #16892 if you want, I was eyeing the name angrily myself

OrionTheFox avatar Oct 23 '22 08:10 OrionTheFox

sure but only if you re-add the suits and ties they were snazzy and professional af i like them :(

Iamgoofball avatar Oct 23 '22 10:10 Iamgoofball

Actually for the best let's keep this seperate, jobcode isn't something I want to even RISK breaking in what's meant to be a sprite/cleanup PR 😱

OrionTheFox avatar Oct 23 '22 12:10 OrionTheFox