Skyrat-tg icon indicating copy to clipboard operation
Skyrat-tg copied to clipboard

[MODULAR] Re-adds the fancy kimono

Open YakumoChen opened this issue 2 years ago • 6 comments

About The Pull Request

I went to play my character best known for their fancy kimono and found out it was gone! What the hell? Put that shit back.

How This Contributes To The Skyrat Roleplay Experience

It has a unique sprite that the recolourable yukata can't replicate. Also, yukatas aren't kimonos.

Changelog

:cl: add: Readds the fancy-looking kimono that looked different from the others. /:cl:

YakumoChen avatar Oct 19 '22 07:10 YakumoChen

THANK YOU, I missed it too.

glitchbow avatar Oct 19 '22 07:10 glitchbow

For the sake of transparency, this item was intentionally removed in https://github.com/Skyrat-SS13/Skyrat-tg/pull/16072.

Nerev4r avatar Oct 19 '22 23:10 Nerev4r

The PR body already addresses that

YakumoChen avatar Oct 20 '22 00:10 YakumoChen

@Ebin-Halcyon I'm not a spriter, I have no idea where to even start with the sprite because I don't see what's low quality about it I can move it to the suit slot pretty easily but I really don't see where the 'low quality' claim comes from. Not really a fair ask.

YakumoChen avatar Oct 22 '22 17:10 YakumoChen

image like, it's got some basic shading already, there's nothing out of place besides the fact it's a fairly big sprite but, that's not a huge deal?

YakumoChen avatar Oct 22 '22 17:10 YakumoChen

@Ebin-Halcyon I'm not a spriter, I have no idea where to even start with the sprite because I don't see what's low quality about it I can move it to the suit slot pretty easily but I really don't see where the 'low quality' claim comes from. Not really a fair ask.

A quick list off of the low quality things of the original sprite

  • Lack of outlines
  • Mediocre colors
  • strangely asymmetrical shading on the arms and other places

Sprites that go more than 3+ pixels off the sprite also look very garish and offputtingly large in game, ala the old victorian dresses. In the end I can't close or merge the PR itself right now, so it's up to other maintainers. I'm just not a fan of the overall quality.

Ebin-Halcyon avatar Oct 22 '22 19:10 Ebin-Halcyon

Sprites that go more than 3+ pixels off the sprite also look very garish and offputtingly large in game, ala the old victorian dresses. In the end I can't close or merge the PR itself right now, so it's up to other maintainers. I'm just not a fan of the overall quality.

Is that why Victorian dresses were removed? I find that ridiculous. I liked both the fancy kimono and the Victorian dress, the latter of which I would also like put back in but I'm new to formatting sprites for BYOND. This is something I would be willing to learn to sprite for, honestly, especially considering how much I value the character I designed with that dress. To me, these sound a little less like "quality" issues and more of difference in personal tastes. I think similar comments were once made about Tallborgs being garish and yet they're the most commonly played cyborg type in the server now.

Ideally, a good fix for the fancy Kimono would to make it colorable, outlined a little better, and maybe edit the sleeve asymmetry, although you can see from the front it is a patterned, asymmetrical style dress. I assume that's what you meant by "other places". ~~Might as well PR to remove Vertical Split on Hair Gradient and Heterochromatic as a trait if we want to complain about sprite symmetry, pff.~~ I really do dislike the removal of content over the adjustment of it.

If the suit slot is needed to justify the pixel size, I'm fine with that as well. It wouldn't be realistic to put a coat over an item like this anyhow.

glitchbow avatar Oct 26 '22 21:10 glitchbow

redoing it in #17196 because of merge conflicts

YakumoChen avatar Oct 27 '22 04:10 YakumoChen