[99% MODULAR] Synth and IPC Unification and Extended Customization!

[RimiNosha]

About The Pull Request

This is part 1 of the Nosha Industries synth overhaul program, and today we're starting simple with making our synths far more modular!

So, in no particular order, cause it's almost 2am, and I am fucking dying of the flu:

• All synths and IPCs are now one race- but wait, there's more!
• Synths now have the ability to choose what head they want!
• Oh, and they can mix and match their bodies and heads too!
  • Sorry, no individual limb customization, that'd bloat too much... Plus, augments exist already.
• Screens now work on both synths and IPCs, not sure where you'd take this, though.
• You can now override, and pick your own hair alpha separate from your race! Hardlight hair, anyone?
• Of course, this comes with an automatic updater, and you should only experience minor tingling in your right leg for a few weeks after installation of this new hardware and firmware! (IPC head colours might reset, sorry, the code would be too messy. Might be fixed by the time this is merged.)
  • NoshaIndustriesisnotliableforanydamageharmormentaltraumacausedbythesechanges.
• Screens now display OVER your eyes, come on man, it's the year 2562, we're way past that stage! (I can't remember the actual date, and I'm far too tired to look it up)
• Also fixes a typo which made the Square Synth screen not work.
• Oh, and picking your components is now way more clean!

Under the hood changes:

• You can now dynamically generate icons from mutant parts using a neat little framework I made.
• Human mobs now have a hair_alpha var that can be used to override their current hair alpha. Might be helpful for funny chems or other such things.
• Added base classes for mutant enabled single checkboxes and single colour pickers.

How This Contributes To The Skyrat Roleplay Experience

Less randomly separated races good, yes? More customization good, yes? Less janky IPC parts showing for non synth races that can't actually use the parts, yes?

Changelog

:cl: del: Nosha Industries has deleted the blueprints for the old Synth and IPC models, and has replaced them with a single, far more modular design. Precautions have been taken to prevent template corruptions. qol: Synths are now way more customizable, and no longer have defunct or superfluous options for themselves and other races! fix: Fixed the IPC Square Synth screen not showing. spellcheck: Standardized punctuation across all Synth parts. refactor: Refactored Synths and IPCs into one highly customizable race, just known as "Synthetic Humanoid". We've yet to find a better name that's all-encompassing. code: Added new base classes for single colour and single checkbox prefs for mutant parts. qol: All races can now customize their hair alpha. qol: IPC screens now display over their eyes, rather than under. qol: Synths now have much nicer to look at customization options, and now have icon previews for all their race-specific options! /:cl:

[RimiNosha]

Itcompilesandrunsonmyendwtfdoyoumean

[Zergspower]

Leg options are gone completely, as are all the synth tails and Snouts aren't working all of my OOC info was wiped as well (flavortext, species lore, headshot, etc etc) it also gave me a last name for some reason?

[RimiNosha]

That makes no sense, considering im direct writing the race, but I'll have a look into it.

[RimiNosha]

Leg options are gone completely

Oh, right. I forgot to mark the race as digi compatible.

as are all the synth tails and Snouts aren't working

Odd. I didn't change any of those files. Might be from my older version of SR.

all of my OOC info was wiped as well (flavortext, species lore, headshot, etc etc)

Didn't get that at all on my end, and I'm unable to recreate it.

it also gave me a last name for some reason?

Odd, but once again, unable to recreate.

[RimiNosha]

Snouts are working just fine with current changes, I have also fixed digitigrade options, and hopefully all but one of the runtimes I'm aware of. Just doing some testing to double make sure.

Just need to hunt down why limb_id is being set to prefs values earlier than it should be.

[RimiNosha]

Ughhhhh, now mismatched heads broke, god I hate limb code.

[Zergspower]

Ughhhhh, now mismatched heads broke, god I hate limb code.

ping me when you want me to retest

[Zergspower]

all my text wiped again on this version (the bottom OOC/Flavor/Headshot etc)

The digi legs are there, the Antenna are listed but dont show.

It hilariously for some reason gave me a last name again

My 'equipment' is now a void and dont show (insert no balls joke here)

The tail selection is still missing synth option and isnt rendering

The Snoot is still not rendering but is showing options now

I'm also getting runtimes like crazy

[Nerev4r]

░░░░░░░░░░░░▄▄ ░░░░░░░░░░░█░░█ ░░░░░░░░░░░█░░█ ░░░░░░░░░░█░░░█ ░░░░░░░░░█░░░░█ ███████▄▄█░░░░░██████▄ ▓▓▓▓▓▓█░░░░░░░░░░░░░░█ ▓▓▓▓▓▓█░░░░ Valve, ░░░░░█ ▓▓▓▓▓▓█░░░░Add This░░░░█ ▓▓▓▓▓▓█░░░░Please!░░░░░█ ▓▓▓▓▓▓█░░░░░░░░░░░░░░█ ▓▓▓▓▓▓█████░░░░░░░░░█ ██████▀░░░░▀▀██████▀

[RimiNosha]

Ah fuck, here we go again...

[github-actions[bot]]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

[RimiNosha]

Verified working with the new stuff!

[RimiNosha]

(Yes, I loaded an old save, pre JSON)

[BriareosBlue]

I can only assume from the "fucking LEGS" comment that this may already be known but yeah, digitigrade legs aren't fully working as the left one appears invisible on chassis options that work with digilegs.

[Rvali]

So here is the bug I witnessed:

• Upon trying to customize characters that were already IPC, their functions are essentially broken entirely. IPC screens and antenna are broken, as well as Tuar legs and fluff or any other mismatched parts that don't typically belong.

• Upon making a new character that was NEVER any of the Synth races, parts are working normally as intended, so the current issue is that old characters are broken.

[RimiNosha]

Yea, it's due to funny sanitization problems, I'm already aware of what needs to be done.

[frontline03]

I've noticed that I can't change the default chassis colour at all Edit: Added photo

[RimiNosha]

I've noticed that I can't change the default chassis colour at all

There was a recolourable one, but I think it was removed by someone else, IIRC. I haven't touched the available IPC chassis.

[RimiNosha]

Wait, no diff was special on the last one. Fixing.

[Zergspower]

something's uh - fucky with the resize, and augments+

fun times but not a super big deal except the augments were wiped clean

I now have an odd growth on my shoulder but only when facing up? The eyes aren't scaling properly anymore for some reason either

[Zergspower]

also some fat runtimes

[RimiNosha]

None of those are my bugs, I think. Resize has always cut off the top of your head on the prefs menu, augments resetting might be due to the too many overlays error you're getting, and the weird growth and scaling are also just byond scaling shenanigans.

The runtime is completely unrelated to this PR, and is a relatively old issue, and it's due to our extreme reliance on sprite accessories to get anything done.

I'll look into the runtime anyways, cause that's gradually been becoming more of an issue as time's gone on.

[TypeVar]

I'm not sure if this is a bug, but the Morpheus Cyberkinetics body doesn't seem to be greyscaled, so it ends up being just white, while the matching head IS greyscaled. I assume this isn't intended so I wanted to notify whoever is working on this PR

Oh and also, the default eyes (cyan thing on the IPC's head on the third image) seem to appear on the side view, which I cannot find a way to fix/remove.

[Rvali]

There seems to be an issue where synths are missing their powercell now, and are therefore unable to eat. Good luck if you are in prison.

[RimiNosha]

The last person to report that bug to me happened to be using a non-synth stomach in augments. Make sure that isn't the case.

[RimiNosha]

OF COURSE SOMEONE CHANGES SYNTH CODE

[GoldenAlpharex]

Fuck this, TGS can't comprehend that this PR is so old and still wanted, I'll have to merge it.