Skyrat-tg icon indicating copy to clipboard operation
Skyrat-tg copied to clipboard

[MDB IGNORE] Updates Departmental Guard icons, sorts files

Open OrionTheFox opened this issue 2 years ago • 9 comments

About The Pull Request

Needed to sort them out so I can cull them from the master uniforms.dmi

Departmental Guard uniforms are now in their departments' .dmi

Comprehensive list of changes for those who want it. Only reason I'm writing this out so thoroughly is that sorting the file makes it look like I removed/added a lot of shittttt

  • update sci utility uniform finally
  • cut a corner off utility uniform obj sprites because it looks sharp and gross
  • removes some extra digi templates (we only need 1, located in color_digi.dmi (move it later? mayb misc?)
  • Fixed the several variants of each item on Black Mesa (What the hell happened here?)
  • Sorts departmental_guards.dm
  • Sets the Science Guard's uniform to entirely use TG's items (they're literally what we already used but up-to-date sprites on ALL of it)
  • The above involved removing and updating extremely old hat/suit icons in the relevant files
  • Gives the Science Guard jackboots to finish the reference
  • Resprites the Orderly Uniform to be white scrubs with gray pants below (Some hospitals use this colorscheme IRL; it's better than the suit and tie)
  • Resprites the Engineering Guard uniform to hi-vis coveralls (At least it looks like engineering wear; hardhat NYI; it's better than a suit and tie)
  • Implements a reworked version of Dragonfruits' resprite of the Customs Agent uniform, with a cargo-colored shirt and charcoal cargoshorts. Looks like a proper cargo uniform. (Again, better than a suit and tie. Why were they all suits and ties?)
  • Updates the customs coat. Still hate it but we can look into tweaks in a suit update PR, this was MEANT to only be uniforms
  • Resprites the Bouncer uniform, simply touching it up to modern standards
  • The Bouncer uniform is now a subtype of the other guard uniforms so it has the same armor
  • Updates the Orderly coat to be evenly shaped on both sides (uneven pattern is still in)
  • Updates the Engineering Guard coat to be even on both sides
  • Slightly updates the departmental guards' beret descriptions to be less meme-y
  • Updates the cargo guards' beret's color to be more accurate
  • Slightly updates job descriptions to read better and be less meme-y (Still funny where it applies though!)
  • Swaps the sci guards' survival box out for the right one; they had the Medical one for some reason
  • Removes redundant comments
Screenshots

image image image

OUTDATED SCREENSHOTS

image image image

How This Contributes To The Skyrat Roleplay Experience

image

~Joke aside, its another step in my damned sprite sorting. With these gone I can start ripping into uniform.dmi itself again, these were stuck in there.~

Changelog

:cl: balance: The Bouncer's uniform has been reinforced with stab-proof thread, expect your wound armor to be on-par with your fellow departmental guards! imageadd: Departmental guards' sprites have been mostly revamped! Expect to fit in a bit better rather than only having suits and ties. /:cl:

OrionTheFox avatar Oct 16 '22 11:10 OrionTheFox

conflicts :(

OrionTheFox avatar Oct 16 '22 11:10 OrionTheFox

oh the conflicts! oh the conflicts!

OrionTheFox avatar Oct 23 '22 08:10 OrionTheFox

I'ma master at what i do 😎

OrionTheFox avatar Oct 23 '22 08:10 OrionTheFox

:-1:. the suits and ties were snazzy, can we keep them as formal attire?

Iamgoofball avatar Oct 23 '22 10:10 Iamgoofball

Updates the Orderly coat to be even on both sides (uneven sprites suck who thought they'd do that) Updates the Engineering Guard coat to be even on both sides (again, why were they even uneven. It just looked messy.)

it was uneven intentionally, try putting your baton on your belt/suit slot and you'll see why it's like that(it was intentional in the design by the spriter)

Iamgoofball avatar Oct 23 '22 10:10 Iamgoofball

also pls give the customs agent his sleeveless coat back

Iamgoofball avatar Oct 23 '22 10:10 Iamgoofball

Drafting this while I work with goof on a few things. He's doing automapper because we lost those at some point, I'm touching up the sprites a bit more instead of the rushed job I did here (already got some real cool ideas)

  • Mulling over how to do the suits back. We have GAGS suit configs now, perhaps we can literally just have preset/armored versions for departmental guards to pick..?
  • Added some uneven-ness back to the Orderly coat; the fold in the coat that Goof mentioned at some point started to shit itself with layering and looked worse because of it, so it's likely not returning
  • Customs agent coat was resprited for way too long. I still don't like it, but its workable, hopefully moreso with the new cargo guard uniform.
  • Engineering Guard uniform now looks based as fuck. The coat will need some reworking but isn't urgent, it can wait for suit sorting

Testing will happen tomorrow. It is 6:30am. This PR does not deserve so much time from me :(

OrionTheFox avatar Oct 23 '22 11:10 OrionTheFox

Functions fine, put the screenshots in for proof of testing

OrionTheFox avatar Oct 24 '22 02:10 OrionTheFox

damn you skyratbot!!

OrionTheFox avatar Oct 25 '22 06:10 OrionTheFox