Skyrat-tg icon indicating copy to clipboard operation
Skyrat-tg copied to clipboard

[MODULARIZING] Removes Foreigner and Adds Quirk Sanitization

Open RimiNosha opened this issue 2 years ago • 3 comments

About The Pull Request

BEFORE YOU REACT WITH 👎, READ!!

We already have foreigner functionality with our current prefs system. This quirk is redundant, and introduces a bunch of weird behavior on our custom species, and honestly, is more effort than it's worth when we've had this underlying functionality since newprefs became a thing.

That, and I'd rather allow people to be foreigner with any language they want!

Also, you're able to start with a recorder at round start with the loadout system, so that's already covered. image image

How This Contributes To The Skyrat Roleplay Experience

Less random language breakages, and allows for some more quirky characters (ironically) than the quirk allowed.

Changelog

:cl: add: Added quirk sanitization. remove: Removed Foreigner. You are able to recreate this quirk almost exactly via removing common, and optionally giving yourself a recorder via loadout. /:cl:

RimiNosha avatar Oct 13 '22 16:10 RimiNosha

foreigner quirk allowed more jobs to be played. consider opening some up, as you have it here it's very strict. e.g: miner

honkpocket avatar Oct 13 '22 18:10 honkpocket

:-1: removing a vanilla /tg/ quirk rather than fixing the bugs created by skyrat's code is not a good idea, foreigner breaking means we have issues with our language code, not that foreigner itself is broken

this is removing the train because a stretch of the rail it drove over is broken

Iamgoofball avatar Oct 13 '22 20:10 Iamgoofball

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

github-actions[bot] avatar Oct 21 '22 00:10 github-actions[bot]