Skyrat-tg
Skyrat-tg copied to clipboard
Skyrat-SS13
Fix/Refactor: MOD tails, tails use defines
About The Pull Request
MOD tails fixed! Fixed the path for 'standart' MOD tail Tail types now use defines instead of strings. Better? I hope so. A little bit of reorganization.
Images:
Feline - Vulpine - Marine - Avian - Straighttail - Shepherdlike - Axolotl - Teshari - Standard
TODO: For some reason, monkey and human (basic felinid) tails are only hidden correctly after the first full-suiting
How This Contributes To The Skyrat Roleplay Experience
Tails are no more compressed inside of MODs!
Changelog
:cl: fix: MOD tails are back again /:cl:
I'd like it if you included some pictures showing some of the tails that weren't working, now working. I'll mark this as ready for a test-merge, just so we can iron out any bugs that would exist with it first.
So, basically just screenshot of MOD with various tails?
I'd like it if you included some pictures showing some of the tails that weren't working, now working. I'll mark this as ready for a test-merge, just so we can iron out any bugs that would exist with it first.
So, basically just screenshot of MOD with various tails?
Yes, specifically the ones that were broken before and are now fixed. Though the more the merrier.
I'd like it if you included some pictures showing some of the tails that weren't working, now working. I'll mark this as ready for a test-merge, just so we can iron out any bugs that would exist with it first.
Done
The colors of the tails don't seem to match the colors of the MODsuit, which is what they're supposed to be doing.
The colors of the tails don't seem to match the colors of the MODsuit, which is what they're supposed to be doing.
Well, I wasn't coloring them, just fixing a bug with them missing at all. They are to be modified on another file, but it should be a different PR in my opinion
EDIT: I also don't have reference images how they looked before emissives PR
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'm honestly not really a fan of how the Feline tail looks for the standard Felinid tail, in all honesty. I'd rather have it kept not using that sprite until we can get a better-suited one.
Other than that, I think we might as well change the colors of the tails to match the MODsuits they're attached to now, so we don't have to wait on someone else to do it.
It's easy to replace the feline MOD tail with something similar, but which one? Standart or Vulpine?
About the coloring... How can I even handle this? Is there a tool to extract colors from the dmi? I have literally zero experience with spriting...
Just wanted to mention there's a refactor (#17372) being worked on which makes this PR obsolete.
Just wanted to mention there's a refactor (#17372) being worked on which makes this PR obsolete.
That's cool!
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.