Skyrat-tg icon indicating copy to clipboard operation
Skyrat-tg copied to clipboard

Bluespace Artillery Overhaul(v2.0)

Open Gandalf2k15 opened this issue 2 years ago • 2 comments

About The Pull Request

I overhauled the BSA a few years ago and the quality of it was not really up to standard so I've decided to overhaul it again and change the way it functions.

Key function changes: The explosion size is dependant on how full the capacitors are. If you have 100 MW you will yield an explosion size of 10/20/40(within bombcap limits). It has a power draw cap of 500KW per cycle. The cannon must now charge capacitors by directly sucking energy from the powernet. The cannon can charge it's capacitors to 100 megawatts.

I have also removed the need for a power coupling; it now just uses the area powernet.

General code cleanup and removal of single-letter vars.

Changelog

:cl: balance: The BSA no longer requires a power coupling and its explosion power depends on how full its internal capacitors are. refactor: The BSA backend has been refactored. /:cl:

Gandalf2k15 avatar Oct 06 '22 17:10 Gandalf2k15

why can't the overhaul as a whole go upstream, considering we're commenting out entire files for it?

Zonespace27 avatar Oct 07 '22 05:10 Zonespace27

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

github-actions[bot] avatar Oct 21 '22 00:10 github-actions[bot]

Merging due to TM conflicts

Gandalf2k15 avatar Apr 02 '23 15:04 Gandalf2k15

MOOOODS THIS MAN IS SELF MERGING

Paxilmaniac avatar Apr 02 '23 15:04 Paxilmaniac