Skyrat-tg icon indicating copy to clipboard operation
Skyrat-tg copied to clipboard

Ghost Hotel Update

Open Kush1Push1 opened this issue 2 years ago • 11 comments

About The Pull Request

Added initial code to add variety of rooms in ghost hotel (a blue ball at Ghost Cafe).

Also, removed annoying bell sound inside rooms.

https://user-images.githubusercontent.com/78963858/192285182-526492b2-62b6-4313-a1d0-49d8aa1742a4.mp4

How This Contributes To The Skyrat Roleplay Experience

A better roleplay experience in Ghost Cafe.

Changelog

:cl: SishTis add: Added rooms variety to ghost cafe's hotel. add: Added fancy cobblestone pool floor. You can reskin pool floor tile in hand to get it. del: Silenced bell ring in ghost cafe's hotel rooms. /:cl:

Kush1Push1 avatar Sep 26 '22 13:09 Kush1Push1

dreamseeker_HFUgBqwnAX

Kush1Push1 avatar Sep 26 '22 16:09 Kush1Push1

I don't think that hidden room in the bottom-right corner should exist.

Done.

Furthermore, the walls you used aren't indestructible walls, which means anyone with a welder could just break into space with it. Which is very much not how it's intended.

Replaced.

The sink looks really awkward placed in the kitchen like that, and I also don't really know if it's really necessary in the first place.

Moved to other place.

The bathroom feels a bit weird, with the washing machine in there. I think it could use a bit more work, I'm not even sure that there's a sink and a mirror in there. You can take a bit more space for it, by removing the hidden room to its right.

It's common for me, but alright. A sink and mirror were there.

The pool in the living room is a bit of a stretch, and I don't think it should be in there, it's too much.

Moved.

Kush1Push1 avatar Sep 26 '22 16:09 Kush1Push1

@GoldenAlpharex ?

image

Kush1Push1 avatar Sep 28 '22 12:09 Kush1Push1

@GoldenAlpharex

tf-4 avatar Oct 05 '22 01:10 tf-4

The wooden decals on the carpet look a bit off, because they're not uniform on any side and contrast heavily with the carpet's very defined edges.

I'm still entirely sold on the pool in the bathroom, unless you're telling me it's supposed to be a bath. In which case, it's a bit big for a bath, but I can see the reasoning. I'd just shrink it down a bit to make it more obvious.

I can't use "iron" at the end, it will override other code.

Code_PH9P8LLimq

dreamseeker_cUYCvQSgo0

I don't think I have enough will to work on it any further. I moved the bath and filled up unused space with a placeholder.

Kush1Push1 avatar Oct 08 '22 09:10 Kush1Push1

Oof -.-

Kush1Push1 avatar Oct 13 '22 14:10 Kush1Push1

My friend and I just got done playtesting the new apartments and... The bathroom floods the entire complex as soon you open the door. There is also a floating painting frame in the living room. Besides that, it was quite fun (and cozy)!

Note: My friend is quite excited for the pool/Japanese style bath to work!

Wildwestmars avatar Oct 14 '22 08:10 Wildwestmars

My friend and I just got done playtesting the new apartments and... The bathroom floods the entire complex as soon you open the door. There is also a floating painting frame in the living room. Besides that, it was quite fun (and cozy)!

Note: My friend is quite excited for the pool/Japanese style bath to work!

Strange, I'll check it 🤔

Kush1Push1 avatar Oct 14 '22 10:10 Kush1Push1

  1. Fixed the map. The pool doesn't spill its water now and the paint was moved back on the wall (there was an issue with its direction).

  2. Added fancy subtype of pool, with look like cobblestone and made it craftable via reskin of pool floor tile.

Kush1Push1 avatar Oct 14 '22 11:10 Kush1Push1

The pool dreamseeker_juE5EomunT

The paint dreamseeker_Lf9nigeuTY

Kush1Push1 avatar Oct 14 '22 11:10 Kush1Push1

The bathroom needs a drain, the water spills and floods the entire room otherwise. Look at how the Cafe's pool does it for an example.

theselfish avatar Oct 20 '22 03:10 theselfish

I tried it myself and apparently that wasn't an issue, the only thing I've noticed is the fishes dying, but that's about it. It's good to send.

GoldenAlpharex avatar Nov 03 '22 00:11 GoldenAlpharex

Your Fix/Feature pull request is currently below zero (-2). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

github-actions[bot] avatar Nov 03 '22 00:11 github-actions[bot]