Skyrat-tg icon indicating copy to clipboard operation
Skyrat-tg copied to clipboard

[Mostly modular] Adds the Picket Sign as an upgrade to all cyborg models

Open Helios7-1 opened this issue 2 years ago • 12 comments

About The Pull Request

This PR aims to add an underused module normally restricted to clown-borgs to the rest of the family of cyborgs in the form of an optional upgrae.

How This Contributes To The Skyrat Roleplay Experience

Clownborgs see usage once every blue moon here. Its harmless in nature because all it does it display an emote. And signs are funny.

Changelog

:cl: add: Add the Metallic nano-sign as an upgrade available to all models of cyborgs! Exercise caution when letting the cyborgs protest! /:cl:

Helios7-1 avatar Sep 20 '22 21:09 Helios7-1

While you're at it unrestrict all of the clown borg modules and let them be used on every model, since borg players are clowns.

Paxilmaniac avatar Sep 20 '22 21:09 Paxilmaniac

This hurts my immersion

YakumoChen avatar Sep 20 '22 21:09 YakumoChen

image Gimmicked in a few times - so good to see it not have to be bussed in - should be default for service for sure

Zergspower avatar Sep 20 '22 21:09 Zergspower

I think it's a good addition. We've done picket signs on other characters and the roleplay as worked out well. Service borg doesn't have much to do, and advertising the bar or anything else is a good idea.

lessthnthree avatar Sep 20 '22 21:09 lessthnthree

It needs to be flavoured in such a way that cutting edge cybernetic unit is not getting a hunk of cardboard with lettering stuffed in it as an upgrade

Even the name "picket sign" does not evoke confidence that this makes sense from an immersive roleplay standpoint

Edit: it was changed

YakumoChen avatar Sep 20 '22 21:09 YakumoChen

Its flavored as "Metallic Nano-sign". It just happens to be a subtype of the actual picket sign and shares the same sprite.

Helios7-1 avatar Sep 20 '22 21:09 Helios7-1

I read the pr again after posting and retracted my statement

YakumoChen avatar Sep 20 '22 21:09 YakumoChen

I personally dont see why it cant be a general upgrade like with the emotives and snack dispenser, opens up various avenues for use especially with ION laws being what they are

Zergspower avatar Sep 26 '22 23:09 Zergspower

I personally dont see why it cant be a general upgrade like with the emotives and snack dispenser, opens up various avenues for use especially with ION laws being what they are

Atomization purposes, try not to expand the scope of already-open PRs

Zonespace27 avatar Sep 26 '22 23:09 Zonespace27

I do not see why this module has to be restricted to service only while a module like the snack dispenser is a general upgrade available to all models. the sign provides no mechanical upgrade or benefit to whatever module it is installed upon.

Helios7-1 avatar Sep 27 '22 15:09 Helios7-1

I personally dont see why it cant be a general upgrade like with the emotives and snack dispenser, opens up various avenues for use especially with ION laws being what they are

Atomization purposes, try not to expand the scope of already-open PRs

ignore me i just saw code chat

Zergspower avatar Sep 27 '22 17:09 Zergspower

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 5 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

github-actions[bot] avatar Oct 12 '22 01:10 github-actions[bot]