Skyrat-tg icon indicating copy to clipboard operation
Skyrat-tg copied to clipboard

VoidRaptor Disposals Conveyor belt and Perma Cryo fixes

Open LovliestPlant opened this issue 2 years ago • 4 comments

About The Pull Request

Fix: https://github.com/Skyrat-SS13/Skyrat-tg/issues/15893 Fix: https://github.com/Skyrat-SS13/Skyrat-tg/issues/15889

Fills in the missing conveyor belt below the recycler in VoidRaptor's disposals. And adds a cryopod and console to perma, near the showers.

How This Contributes To The Skyrat Roleplay Experience

Disposals will be able to cycle properly, and prisoners will have the option to cryo if they so choose.

Changelog

:cl: add: Adds a cryopod to VoidRaptor's permabrig. fix: Resolve missing conveyor belt in VoidRaptor's disposals. /:cl:

VR_PermaCryo

LovliestPlant avatar Sep 01 '22 18:09 LovliestPlant

If you do Fix: #pr or Fixes: #pr It'll automatically link the issue number and, once this PR is merged, close the issues.

Jolly-66 avatar Sep 01 '22 20:09 Jolly-66

Where abouts? In the body or in the CL?

LovliestPlant avatar Sep 01 '22 23:09 LovliestPlant

Where abouts? In the body or in the CL?

The CL is for player-facing information, putting it there would be useless to those who don't use GitHub.

Put it in the PR body.

Jolly-66 avatar Sep 01 '22 23:09 Jolly-66

Okay, I think I did it right?

LovliestPlant avatar Sep 02 '22 00:09 LovliestPlant

Okay, I think I did it right?

image All good! It also works with "Closes #" or "Fixes #", no need for the : if you prefer to be lazy (like me)

OrionTheFox avatar Sep 03 '22 08:09 OrionTheFox

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 5 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

github-actions[bot] avatar Sep 11 '22 00:09 github-actions[bot]

probably want to avoid this going stale

Zergspower avatar Sep 19 '22 16:09 Zergspower

oops. Welp. I fixed the thing.

LovliestPlant avatar Sep 19 '22 18:09 LovliestPlant