Skyrat-tg
Skyrat-tg copied to clipboard
[MODULAR] Fixes That Stupid Language Reset Bug That's Been Here Since Newprefs
About The Pull Request
Fixes that stupid bug that resets your languages when you get slapped with a SAD or anything else that fucks with loading prefs.
Literally gandalf's fault. https://github.com/Iamgoofball/Skyrat-tg/blob/fixing_dat_jobs/modular_skyrat/master_files/code/modules/client/preferences/middleware/languages.dm
Also brings foreigner in line with the server's general ethos by making it give uncommon to races other than human too.
This is mostly a byproduct of a fix I was trying to make for foreigner specfically, and it didn't make sense in my eyes to make a second PR that edits this PRs code.
Closes #12802 Closes #15245 Closes #15823
How This Contributes To The Skyrat Roleplay Experience
Admins now want to commit server explode slightly less.
Also less bugs, and less angry messages about prefs code in general.
Changelog
:cl: fix: Fixed that stupid language reset bug with the SAD and other things that's been around since newprefs. balance: Races other than human are now given uncommon by default with the Foreigner quirk. /:cl:
Be aware this breaks foreigner in it's current state, and it's been an absolute headache fixing it in a non-cursed way.
Fixed foreigner, but a byproduct of the changes is that uncommon is given to races other than human when they select foreigner. Can be removed and specifically checked against if folk want, but this just seems silly to keep TG behavior on.
every qdel in here is incorrect, byond will garbage collect them as soon as the proc run ends as nothing holds a ref to them anymore.