Gherman

Results 41 comments of Gherman

I’m refactoring the `env`crate to make agnostic of `OnInstance` implementation as part of the #1279. This might also be relevant for this issue https://github.com/paritytech/ink/compare/master...gn/configurable-buffer

It is a good spot we should make `AccountId` more generic. The fix in tests should easy. However, the reason why you might not be able to instantiate the contract...

> Do you mean `pallet-contracts` defaults to `AccountId32` Essentially, yes, `substrate-contracts-node` using `AccountId32` which resolves to `[u8; 32]`. Off-chain testing environment makes an assumption about this in order to generate...

After some investigation, it would be difficult to support non-standard generic account types in both unit and e2e testing. This is due to the fact that the testing environment assumes...

What's the status of this? Are you going to tackle it anytime soon? if not, can I take over the issue?

> This is expected behaviour, the `ident` is used as part of the storage key calculation process. > > https://github.com/paritytech/ink/blob/97f90ca6d032ecea1b0ff173ddde5ba0c18e1b30/crates/ink/codegen/src/generator/storage_item.rs#L213-L219 This implies that devs working with multi-contract projects with the...

> > > This is expected behaviour, the `ident` is used as part of the storage key calculation process. > > > https://github.com/paritytech/ink/blob/97f90ca6d032ecea1b0ff173ddde5ba0c18e1b30/crates/ink/codegen/src/generator/storage_item.rs#L213-L219 > > > > > > This...

@deuszx see https://github.com/paritytech/ink/issues/1825#issuecomment-1606925832 from Hernando. Having an identical storage layout is required for delegate calls when contract B delegates to operate on contract A's storage. In this case, contract B...

That should be `cargo-contract` issue

@HCastano Can you please let me know if the issue is still relevant?