QHotkey icon indicating copy to clipboard operation
QHotkey copied to clipboard

Bump Qt versions and Qt acquisition script

Open Cuperino opened this issue 2 months ago • 2 comments

Bumping the Qt acquisition script should fix build errors in CI.

Cuperino avatar Apr 25 '24 13:04 Cuperino

I've bumped the versions to the latest micro versions available. Nevertheless, the Qt 5s fail to build, with linker undefined symbol errors that occur after bumping jurplel/install-qt-action.

Cuperino avatar Apr 25 '24 14:04 Cuperino

Looks like on MacOS it tries to build it for ARM, but Qt binaries are for x86.

Shatur avatar Apr 25 '24 14:04 Shatur

@Shatur I got CI fixed for all systems using CMake. I couldn't get the qmake build to work with Windows, I don't normally work on Windows and QMake is being phased out anyways, so I opted to remove those builds from CI in the end.

Feel free to re-add them and fix whatever issue is left. Here is the commit that got the closest to getting qmake to work everywhere: 57525e01402bd21c36225858147470861b80f720

Cuperino avatar May 19 '24 22:05 Cuperino

I'm on board with removing qmake. Could you remove the qmake file completely?

Shatur avatar May 20 '24 08:05 Shatur

Done. All files pertaining qmake have been removed.

Cuperino avatar May 20 '24 13:05 Cuperino

Thank you!

Shatur avatar May 20 '24 13:05 Shatur