Skyblocker icon indicating copy to clipboard operation
Skyblocker copied to clipboard

Migrate some features from my discontinued fork

Open Blue-Beaker opened this issue 1 year ago • 4 comments

Describe the new feature.

I had a discontinued skyblocker fork of 1.16.5, which contains some good features/implementations to implement in skyblocker.

[New Feature] Wishing compass locator, which stores rays from the particles, and calculates the target with 2 rays code

[Improvement] Optimized metal detector locator, which works when moving (uses sound position of metal detector, needs to turn off music), and shows probable blocks when scanning code video

[New Feature]network relay solver (shows pitch) code

[Improvement] Crystal hollows waypoints grouped by lobby id. exiting and rejoining the same lobby persists the waypoints, autoremoves when a lobby is closed code

[New Feature] Potion types overlay code

[New Feature] Shows HoTM perk Levels code

[Improvement] Add/modify/remove waypoints with commands code

[Improvement]Vanilla-style cooldown display (display cooldown like the ender-pearl does) code

If you are interested in any features in my fork, feel free to migrate it.

here is the repo

Images

2022-10-10_15 23 16 Divan located by wishing compass locator with 2 rays shown on the picture Sorry for no image for metal locator because my network is too laggy for playing crystal hollows in 1.16.5. However you can still try it out using the release of my fork as long as skyblock still supports 1.16.5Solved, use AoTE after joining crystal hollows to load chunks in MC1.16.5 Video of how my wishing compass locator and metal detector locator works: video

Screenshot_20240811_121815 Wishing compass locator Screenshot_20240811_125116 Screenshot_20240811_125102 item overlays

Blue-Beaker avatar Aug 11 '24 05:08 Blue-Beaker

I actually think most of these have stumbled their way into the main branch now

Crystal hollows waypoints grouped by lobby id

Not 100% sure on the implementation of this on the main branch but I believe it also works with other skyblocker players sending ithe info to the server and then other players can get the info :D

BigloBot avatar Aug 11 '24 12:08 BigloBot

I think these 3 would be potentially missing from the main branch

network relay solver
Potion types overlay
Vanilla-style cooldown display (display cooldown like the ender-pearl does)

BigloBot avatar Aug 11 '24 12:08 BigloBot

Network relay solver is one of the thing i have done in 1.19.2 but not yet upstream + it needed a rewrite to be better

Julienraptor01 avatar Aug 11 '24 12:08 Julienraptor01

maybe also check my metal detector locator implementation, it doesn't need the player to stand still(even works when running and jumping), and shows several possible locations when it cant be reduced to one yet (so the player can do it faster)

Adding these 2 features to the existing one will be enough.

Besides, HoTM levels display will also be great.

2024年8月11日 20:12:06 BigloBot @.***>:

I think these 3 would be potentially missing from the main branch

*network relay solver Potion types overlay Vanilla-style cooldown display (display cooldown like the ender-pearl does) * — Reply to this email directly, view it on GitHub[https://github.com/SkyblockerMod/Skyblocker/issues/912#issuecomment-2282739086], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AECSTG2YBADCIXA6YYCUT33ZQ5IJHAVCNFSM6AAAAABMKNRZYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSG4ZTSMBYGY]. You are receiving this because you authored the thread.[追踪用途的图像][https://github.com/notifications/beacon/AECSTG4NOTRC6KYTVRGHRO3ZQ5IJHA5CNFSM6AAAAABMKNRZYWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUIB7KY4.gif]

Blue-Beaker avatar Aug 11 '24 16:08 Blue-Beaker