SkyblockerMod
Dungeon entrance room's physical pos sometimes gets misdetected
What happened?
Rarely, the entrance room for dungeons gets detected at the wrong location, which breaks the new door highlighter added by #879, as it relies on the map to determine door positions instead of detecting blocks.
It seems to also break secret detection but I haven't seen this happen enough times to confirm if it is really the root cause for that issue.
Screenshots
No response
Log output
Problematic detection :
[12:41:13] [Render thread/INFO]: [Skyblocker Dungeon Secrets] Started dungeon with map room size 16, map entrance pos ( 8.500E+1 1.050E+2), player pos (-57.13406938252408, 69.0, -34.940132857258206), and physical entrance pos (-8.000E+0 -8.000E+0)
Accurate detection :
[12:17:34] [Render thread/INFO]: [Skyblocker Dungeon Secrets] Started dungeon with map room size 16, map entrance pos ( 2.500E+1 1.050E+2), player pos (-152.41298109209808, 69.0, -36.86233108903359), and physical entrance pos (-1.680E+2 -4.000E+1)
Minecraft Version
1.21.0
Skyblocker Version
Any with dungeon features
Additional context
Regarding the above log, in very few cases, the detected physical position is wrong, though the map pos remain accurate. (refer to player coords & physical room coords, and you'll see they don't match)
This fortunately remains really rare, and for most runs, no issues are experienced.
Aaron said that this only happens when the physical entrance pos is (-8.000E+0 -8.000E+0). I'm putting this here so we can investigate later.
I was playing dungeons with my friend earlier (both using latest version of the mod) and the secret waypoints broke for him but not me meaning this issue must have something to do with it being detected at the wrong time or something else similar rather than this being caused by specific room combinations.
When I encountered this situation, the server was always a little laggy (low TPS at the beginning). If players can restart the detection process through a command in game, it may help with this problem.
#1200 Should hopefully fix this, if you encounter this issue again please let us know.
#1200 helps to mitigate the this, though the issue remains.
I'll update this the next time the issue is encountered, as I've lost the relevant logs (the issue is quite uncommon nowadays).