Skyblocker icon indicating copy to clipboard operation
Skyblocker copied to clipboard

Published 20 hours ago • verified publisher icon SkyblockerMod

Sign calculator

Open olim88 opened this issue 9 months ago • 10 comments

adds ability to do calculations when inputting number into signs and a calculate command

sign input

image image

command

image image

I have created custom calculator utility for this using a shunting yard algorithm to convert calculation to RPN and then calculating the answer. it also supports (s, k, m, b) and created tests for this.

also tested in game bazaar and ah

olim88 avatar May 05 '24 11:05 olim88

Another banger by olim. Do you think it would be doable to have an interface that a screen could implement to have it somewhere else? i.e. the popup to set the price/bid in fancy AH.

viciscat avatar May 05 '24 14:05 viciscat

implement to have it somewhere else

This should not be to hard. If the renderSign method in SignCalculator to a location (add possible renamed) then it should work were ever this is called. is this the sort of thing you meant

olim88 avatar May 05 '24 15:05 olim88

add "e" for "enchanted", equals 160 (2.5 stacks)

Fluboxer avatar May 05 '24 16:05 Fluboxer

This should not be to hard. If the renderSign method in SignCalculator to a location (add possible renamed) then it should work were ever this is called. is this the sort of thing you meant

yea that's good enough

viciscat avatar May 05 '24 16:05 viciscat

Maybe only works if you have a = sign in front like =4s * 5. Also would be nice to have purse be the number of coins you have in your purse.

kevinthegreat1 avatar May 05 '24 16:05 kevinthegreat1

add "e" for "enchanted" have purse be the number of coins you have in your purse

good idea. i have added this and put a key in the tooltip so players know its there

Maybe only works if you have a = sign in front

i feel like this is a nice idea and some will like it however i like to be reassured what the value of the sign is going to be even if i am just doing something like 1.02k so i have made it a toggle in the settings so both options are available

olim88 avatar May 06 '24 17:05 olim88

last nitpick and I think this PR will be good, add "p" for "purse" maybe? to make it easier and faster to type

viciscat avatar May 07 '24 21:05 viciscat

last nitpick and I think this PR will be good, add "p" for "purse" maybe? to make it easier and faster to type

I still don't get how this one would be useful tho

Fluboxer avatar May 07 '24 23:05 Fluboxer

I still don't get how this one would be useful tho

make it faster to type or something, faster to type "p" than "purse"

viciscat avatar May 08 '24 10:05 viciscat

Can you do git pull master and git rebase master instead of merging master.

kevinthegreat1 avatar May 09 '24 21:05 kevinthegreat1