Skyblocker icon indicating copy to clipboard operation
Skyblocker copied to clipboard

added 2 extra quick nav tabs

Open VeritasDL opened this issue 10 months ago • 7 comments

added 2 extra quick nav tabs and tweaked rendering to accommodate the new tabs

VeritasDL avatar Apr 08 '24 20:04 VeritasDL

Thank you for your pull request. This is a great pr but there seems to be some slight disagreement due to the reordering of this feature. In addition with the large volume of pr's we have right now, please allow some time for review. Your pr has been put in bleeding edge, and you can download the newest bleeding edge build here.

kevinthegreat1 avatar Apr 12 '24 14:04 kevinthegreat1

I think I've added a working config for disabling the extra tabs, I'm sure the codes straight spaghetti but ¯_(ツ)_/¯

VeritasDL avatar Apr 13 '24 02:04 VeritasDL

I said this on discord but just so the information is on GitHub too:

Since this restructures the config, we're waiting until 1.20.5 is merged and will include this when we overhaul the config, to not mess up people's quick nav configs, which will likely be the next update.

Marking as wip for now.

kevinthegreat1 avatar May 04 '24 22:05 kevinthegreat1

Conflicts with datafixer pr. Will need to wait for #701 to be merged.

kevinthegreat1 avatar May 11 '24 21:05 kevinthegreat1

Hey can you please do a quick rebase? Then I can add the config shifting and data fixer stuff, unless you want to do it.

kevinthegreat1 avatar May 14 '24 01:05 kevinthegreat1

WIP. Defaults and data fixer needs to be added.

kevinthegreat1 avatar May 15 '24 16:05 kevinthegreat1

Basically rewrote quick nav. Screenshot 2024-05-15 at 16 48 29Screenshot 2024-05-15 at 16 48 37

kevinthegreat1 avatar May 15 '24 20:05 kevinthegreat1