Skyblocker icon indicating copy to clipboard operation
Skyblocker copied to clipboard

Make wither effect visible on the fancy health bar

Open edgarogh opened this issue 2 years ago • 1 comments

Issue

The health bar remains red when the player has a wither effect, which is not what most players would expect. It also simply makes it hard to tell that something is "wrong".

To do

  • Add a new bar sprite in /src/main/resources/assets/skyblocker/textures/gui/bars.png (probably to the right of the first row, around x=106 y=1)
  • Add a new heart sprite (where?)
  • Add a condition on this line to handle the case "health bar && withering" and offset the y coordinate of the bar texture https://github.com/LifeIsAParadox/Skyblocker/blob/17bbd926da6c16149ce8d3bf07837aa2f04243ff/src/main/java/me/xmrvizzy/skyblocker/skyblock/FancyStatusBars.java#L102 Same goes for the heart texture

The wither effect can be trivially detected with MinecraftClient.getInstance().player.hasStatusEffect(StatusEffects.WITHER).


I can do the job myself and have it done by the end of the weekend if you're interested.

edgarogh avatar Apr 01 '22 23:04 edgarogh

the bar maybe could go deep red or black or even red stripped black

Julienraptor01 avatar Oct 31 '22 21:10 Julienraptor01