Skyblocker icon indicating copy to clipboard operation
Skyblocker copied to clipboard

Update Livid and Mimic msg to send in party chat

Open WhatYouThing opened this issue 11 months ago • 8 comments

WhatYouThing avatar Mar 23 '24 00:03 WhatYouThing

That should have a settings entry to choice if you want to use party chat for that

Fluboxer avatar Mar 23 '24 15:03 Fluboxer

agreed with Fluboxer

viciscat avatar Mar 25 '24 19:03 viciscat

Score messages are always sent to the party chat, so I thought it would only make sense for these to also send to the party chat. Is there a specific reason for them sending to the all chat?

WhatYouThing avatar Mar 26 '24 09:03 WhatYouThing

What happens with /pc when you're not in a party?

kevinthegreat1 avatar Mar 26 '24 15:03 kevinthegreat1

What happens with /pc when you're not in a party?

it will do this, even if you are not in party

изображение

Fluboxer avatar Apr 03 '24 10:04 Fluboxer

Is there consensus on this pr?

kevinthegreat1 avatar Apr 05 '24 19:04 kevinthegreat1

my answer is no. I mean, it takes like a minute to code it into toggle-able setting

Fluboxer avatar Apr 05 '24 19:04 Fluboxer

while working on messages for my pr I noticed that... all score messages are trying to be sent in party chat? изображение

I still consider this to be cancerous practice - there is no reason why you should hardcode that instead of either giving player a choice or just not doing so (/chat party exists)

Fluboxer avatar Apr 07 '24 13:04 Fluboxer